This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RE: [PATCH][MIPS] Fix register renaming in the interrupt handlers
- From: Robert Suchanek <Robert dot Suchanek at imgtec dot com>
- To: "Moore, Catherine" <Catherine_Moore at mentor dot com>, Mike Stump <mikestump at comcast dot net>, Richard Sandiford <rdsandiford at googlemail dot com>
- Cc: Matthew Fortune <Matthew dot Fortune at imgtec dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 18 Aug 2015 12:46:24 +0000
- Subject: RE: [PATCH][MIPS] Fix register renaming in the interrupt handlers
- Authentication-results: sourceware.org; auth=none
- References: <B5E67142681B53468FAF6B7C31356562441B01AD at hhmail02 dot hh dot imgtec dot org> <87k2szc6b9 dot fsf at googlemail dot com> <4438A5B8-6266-4E4F-A43C-8BA503A08900 at comcast dot net> <B5E67142681B53468FAF6B7C31356562441B05D2 at hhmail02 dot hh dot imgtec dot org> <FD3DCEAC5B03E9408544A1E416F112420192C94C70 at NA-MBX-04 dot mgc dot mentorg dot com>
Hi,
> > gcc/
> > * config/mips/mips-protos.h (mips_hard_regno_rename_ok): New
> > prototype.
> > * config/mips/mips.c (mips_hard_regno_rename_ok): New
> > function.
> > (mips_hard_regno_scratch_ok): Likewise.
> > (TARGET_HARD_REGNO_SCRATCH_OK): Define macro.
> > * config/mips/mips.h (HARD_REGNO_RENAME_OK): New.
> >
> > gcc/testsuite/
> > * gcc.target/mips/interrupt_handler-bug-1.c: New test.
> > ---
>
> Based on the feedback from Richard and Mike, this looks OK now.
> Thanks,
> Catherine
Committed as r226968.
I slightly modified the test to search for "^isr:.*\\\$8.*isr"
instead of just "\\\$8" as with the ToT compiler 2 tests failed with -flto.
It happened that $8 appeared in the LTO bytecode. Changed as obvious.
Regards,
Robert