This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix middle-end/67133, part 1
- From: Marek Polacek <polacek at redhat dot com>
- To: Jeff Law <law at redhat dot com>
- Cc: Richard Biener <richard dot guenther at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 14 Aug 2015 17:32:24 +0200
- Subject: Re: [PATCH] Fix middle-end/67133, part 1
- Authentication-results: sourceware.org; auth=none
- References: <20150814112006 dot GR3335 at redhat dot com> <CAFiYyc2P_d=h=QHGjoDi0uONLFbe3gmKPvcDcABwOsvSBHuZyw at mail dot gmail dot com> <20150814132945 dot GS3335 at redhat dot com> <55CE002E dot 6000108 at redhat dot com>
On Fri, Aug 14, 2015 at 08:50:22AM -0600, Jeff Law wrote:
> On 08/14/2015 07:29 AM, Marek Polacek wrote:
> >On Fri, Aug 14, 2015 at 03:14:10PM +0200, Richard Biener wrote:
> >>On Fri, Aug 14, 2015 at 1:20 PM, Marek Polacek <polacek@redhat.com> wrote:
> >>>As outlined in the PR, this fixes one ICE. The code in question here
> >>>tries to determine whether OP can be derived as non-NULL. In case the
> >>>function has the nonnull attribute that applies to all the arguments,
> >>>we want to see whether OP is in this argument list. But nonnull only
> >>>appertains to pointers. Some ssa_names don't have a type so check for
> >>>that first instead of segv before looking at its tree code.
> >>
> >>Huh? All but released SSA names have a type. So this gets invoked on dead code
> >
> >I suppose so. It gets
> > <ssa_name 0x7ffff1890948 nothrow var <var_decl 0x7ffff188df30 c>def_stmt
> >
> > version 13 in-free-list>
> >
> >(it didn't ICE before r209891 because the operand_equal_p check came first and
> >returned false so we didn't check the type).
> Let's track this down -- nothing should be referencing anything in the
> SSA_NAME freelist.
Ok, I'll investigate and come back to y'all when/if I find something.
Marek