This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, rs6000] Fix source operand contraints for tabort. pattern
- From: David Edelsohn <dje dot gcc at gmail dot com>
- To: Peter Bergner <bergner at vnet dot ibm dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Tulio Magno Quites Machado Filho <tuliom at linux dot vnet dot ibm dot com>, "Paul E. Murphy" <murphyp at linux dot vnet dot ibm dot com>
- Date: Mon, 3 Aug 2015 16:27:17 -0400
- Subject: Re: [PATCH, rs6000] Fix source operand contraints for tabort. pattern
- Authentication-results: sourceware.org; auth=none
- References: <1438630768 dot 5030 dot 8 dot camel at otta>
On Mon, Aug 3, 2015 at 3:39 PM, Peter Bergner <bergner@vnet.ibm.com> wrote:
> This patch fixes an oversight in the tabort. pattern (only generated via
> the __builtin_tabort (cause) builtin), which currently allows using r0.
> The problem is that if r0 is used, the "cause" argument value passed in
> by the user will be ignored, since using r0 means the value zero and not
> the contents of r0 (similar to base registers in loads/stores, addi, etc.).
> This patch restricts the tabort. pattern to only use base registers.
>
> This has passed bootstrapping and regtesting on trunk. Ok for mainline?
>
> I'd like to also backport this to the release branches. Is this ok for
> them once bootstrapping and regtesting are complete on them?
>
> Peter
>
> gcc/
> * config/rs6000/htm.md (tabort.): Restrict the source operand to
> using a base register.
>
> gcc/testsuite/
> * gcc.target/powerpc/htm-tabort-no-r0.c: New test.
Okay.
Thanks, David