This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PR66726] Factor conversion out of COND_EXPR
- From: Jeff Law <law at redhat dot com>
- To: Kugan <kugan dot vivekanandarajah at linaro dot org>, Bernhard Reutner-Fischer <rep dot dot dot nop at gmail dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 3 Aug 2015 10:59:10 -0600
- Subject: Re: [PR66726] Factor conversion out of COND_EXPR
- Authentication-results: sourceware.org; auth=none
- References: <55974BF2 dot 3060603 at linaro dot org> <20150704085143 dot GA14895 at nbbrfq dot cc dot univie dot ac dot at> <5597D24B dot 8010900 at linaro dot org> <559AF515 dot 6010700 at redhat dot com> <559BCB15 dot 9010209 at linaro dot org> <559BE505 dot 5070802 at redhat dot com> <559EFEE5 dot 6030006 at linaro dot org> <55A02DBF dot 6030608 at redhat dot com> <55A24E7D dot 4080609 at linaro dot org> <55A6073D dot 1020800 at linaro dot org> <55A6AA4D dot 1030106 at redhat dot com> <55A74691 dot 3050303 at linaro dot org> <55B13AF0 dot 3020204 at redhat dot com> <55B583F6 dot 4080904 at linaro dot org>
On 07/26/2015 07:05 PM, Kugan wrote:
I thought that when !gimple_assign_cast_p (stmt), RHS will always
boolean. I have now added this check in the attached patch.
Thanks.
I also noticed that in maybe_optimize_range_tests, GIMPLE_COND can
have non compatible types when new_op is updated
(boolean types coming from tcc_compare results) and hence need to be
converted. Changed that as well.
Did you find this by examination or with some testcode? If the latter,
including a testcase for this issue would be appreciated.
Bootstrapped and regression tested on x86-64-none-linux-gnu with no new
regressions. Is this OK for trunk?
OK with an updated changelog.
Jeff