This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 1/4][ARM][PR target/65697][5.1] Backport stronger barriers for __sync fetch-op builtins.
- From: Ramana Radhakrishnan <ramana dot radhakrishnan at foss dot arm dot com>
- To: Matthew Wahab <matthew dot wahab at foss dot arm dot com>, gcc-patches at gcc dot gnu dot org
- Date: Fri, 31 Jul 2015 10:36:04 +0100
- Subject: Re: [PATCH 1/4][ARM][PR target/65697][5.1] Backport stronger barriers for __sync fetch-op builtins.
- Authentication-results: sourceware.org; auth=none
- References: <559538D3 dot 8010302 at foss dot arm dot com> <55B60823 dot 6070905 at foss dot arm dot com>
On 27/07/15 11:29, Matthew Wahab wrote:
> Ping. Updated patch attached.
>
> Also, retested for arm-none-linux-gnueabihf with native bootstrap and make
> check and for arm-none-eabi with cross compiled make check.
>
> On 02/07/15 14:12, Matthew Wahab wrote:
>> The __sync builtins are implemented using barriers that are too weak for ARMv8
>> targets, this has been fixed on trunk for the ARM back-end. Since GCC-5.1 is
>> also generating the incorrect code, it should also be fixed.
>>
>> This patch backports the changes made to strengthen the barriers emitted for
>> the __sync fetch-and-op/op-and-fetch builtins.
>>
>> The trunk patch submission is at
>> https://gcc.gnu.org/ml/gcc-patches/2015-06/msg01410.html
>> The commit is at https://gcc.gnu.org/ml/gcc-cvs/2015-06/msg01235.html
>>
>> Tested the series for arm-none-linux-gnueabihf with check-gcc
>>
>> Ok for the branch?
>> Matthew
>>
>> 2015-07-02 Matthew Wahab <matthew.wahab@arm.com>
>>
>> Backport from trunk:
>> 2015-06-29 Matthew Wahab <matthew.wahab@arm.com>
>>
>> PR target/65697
>> * config/armc/arm.c (arm_split_atomic_op): For ARMv8, replace an
>> initial acquire barrier with final barrier.
>
This is OK thanks,
Ramana