This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: C++ delayed folding branch review

On 07/30/2015 05:02 PM, Jason Merrill wrote:


Actually ME deals with none-cannonical form too.  It just asserts on
it at this place.  After delayed-folding work I will continue work
(Jeff pushed first parts of this work already to ML) on eliminating
use of shorten_compare completely, and move its folding-patterns to
match.pd.


It looks like c_finish_omp_for should have done this canonicalization
for the condition.  And various places assume that the OMP for condition
has had this canonicalization done, this is just the only place there's
an assert.  We need to make sure that it's done, somehow.
One possibility would be to try to get Richi to accept the canonicalization patterns to match.pd without removing the equivalent code from shorten_compare.
That might fix the problem y'all are running into without regressing on the warning that I ran into (I haven't tested that). 

Thoughts?

jeff
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]