This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 0/9] start converting POINTER_SIZE to a hook
- From: Richard Sandiford <rdsandiford at googlemail dot com>
- To: David Edelsohn <dje dot gcc at gmail dot com>
- Cc: Richard Earnshaw <Richard dot Earnshaw at foss dot arm dot com>, tbsaunde+gcc at tbsaunde dot org, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 30 Jul 2015 22:33:52 +0100
- Subject: Re: [PATCH 0/9] start converting POINTER_SIZE to a hook
- Authentication-results: sourceware.org; auth=none
- References: <CAGWvnynL3f=xWxw1C165mdBiUhZ2W4Tv9SPAncHHCMAktg71-g at mail dot gmail dot com>
David Edelsohn <dje.gcc@gmail.com> writes:
> On Wed, Jul 29, 2015 at 11:16:40AM +0100, Richard Earnshaw wrote:
>> I'm getting a bit worried about the potential performance impact from
>> all these indirect function call hooks. This is a good example of when
>> it's probably somewhat unnecessary. I doubt that the compiler could
>> function correctly if this ever changed in the middle of a function.
>
> +1
FWIW, the thread has already moved on from the idea of calling this hook
each time POINTER_SIZE is used.
The idea of caching POINTER_SIZE should if anything make things quicker,
since on many modern targets POINTER_SIZE depends on command-line options
and the values of those options are tested each time POINTER_SIZE is used.
Thanks,
Richard