This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: fixup gomp register/unregister prototypes
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Nathan Sidwell <nathan at acm dot org>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 17 Jul 2015 16:44:17 +0200
- Subject: Re: fixup gomp register/unregister prototypes
- Authentication-results: sourceware.org; auth=none
- References: <55A6AEBE dot 5090406 at acm dot org>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, Jul 15, 2015 at 03:04:30PM -0400, Nathan Sidwell wrote:
> I'm almost tempted to commit as obvious. I noticed that the callers of
> these functions from code generated by mkoffload declare the 2nd arg as an
> int, because they have no visibility of the enum. I thought it wise to make
> the definitions match.
I think it doesn't really matter that much, such an enum on all targets we care
about is passed the same way as int.
But if you think it is important, I don't really care either way.
> 2015-07-15 Nathan Sidwell <nathan@codesourcery.com>
>
> * target.c (GOMP_offload_register): Use int for device type arg.
> (GOMP_offload_unregister): Likewise.
Jakub