This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [gomp] Move openacc vector& worker single handling to RTL

From: Nathan Sidwell <nathan at acm dot org>
To: Thomas Schwinge <thomas at codesourcery dot com>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Jakub Jelinek <jakub at redhat dot com>
Date: Tue, 14 Jul 2015 20:00:59 -0400
Subject: Re: [gomp] Move openacc vector& worker single handling to RTL
Authentication-results: sourceware.org; auth=none
References: <5597120D dot 2080308 at acm dot org> <20150703231159 dot GP10247 at tucnak dot redhat dot com> <559844EF dot 6010208 at acm dot org> <559AD85B dot 2050102 at acm dot org> <20150707095408 dot GD10247 at tucnak dot redhat dot com> <559BDE68 dot 9010302 at acm dot org> <20150707142229 dot GG10247 at tucnak dot redhat dot com> <559D381C dot 7020804 at acm dot org> <20150708145822 dot GB10247 at tucnak dot redhat dot com> <559D9A29 dot 2020409 at acm dot org> <559F10F2 dot 9050102 at acm dot org> <87mvyzywlg dot fsf at kepler dot schwinge dot homeip dot net>

On 07/14/15 04:25, Thomas Schwinge wrote:

  	addr = gen_rtx_MEM (mode, addr);
  	addr = gen_rtx_UNSPEC (mode, gen_rtvec (1, addr), UNSPEC_SHARED_DATA);
-	if (pm & PM_read)
+	if (pm == PM_read)
  	  res = gen_rtx_SET (addr, reg);
-	if (pm & PM_write)
+	else if (pm == PM_write)
  	  res = gen_rtx_SET (reg, addr);
+	else
+	  gcc_unreachable ();


OK. or maybe assert (pm == PM_write) inside the else?  your call

nathan

References:
- [gomp] Move openacc vector& worker single handling to RTL
  - From: Nathan Sidwell
- Re: [gomp] Move openacc vector& worker single handling to RTL
  - From: Jakub Jelinek
- Re: [gomp] Move openacc vector& worker single handling to RTL
  - From: Nathan Sidwell
- Re: [gomp] Move openacc vector& worker single handling to RTL
  - From: Nathan Sidwell
- Re: [gomp] Move openacc vector& worker single handling to RTL
  - From: Jakub Jelinek
- Re: [gomp] Move openacc vector& worker single handling to RTL
  - From: Nathan Sidwell
- Re: [gomp] Move openacc vector& worker single handling to RTL
  - From: Jakub Jelinek
- Re: [gomp] Move openacc vector& worker single handling to RTL
  - From: Nathan Sidwell
- Re: [gomp] Move openacc vector& worker single handling to RTL
  - From: Jakub Jelinek
- Re: [gomp] Move openacc vector& worker single handling to RTL
  - From: Nathan Sidwell
- Re: [gomp] Move openacc vector& worker single handling to RTL
  - From: Nathan Sidwell
- Re: [gomp] Move openacc vector& worker single handling to RTL
  - From: Thomas Schwinge

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]