This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [C++ Patch] Prefer error + inform to two errors in check_template_shadow

From: Jason Merrill <jason at redhat dot com>
To: Paolo Carlini <paolo dot carlini at oracle dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
Date: Tue, 14 Jul 2015 11:07:15 -0400
Subject: Re: [C++ Patch] Prefer error + inform to two errors in check_template_shadow
Authentication-results: sourceware.org; auth=none
References: <55A3C015 dot 3070105 at oracle dot com>

On 07/13/2015 09:41 AM, Paolo Carlini wrote:

+++ testsuite/g++.dg/template/crash81.C	(working copy)
@@ -3,6 +3,6 @@
  struct A
  {
    template<T::X> struct X; // { dg-error "'T' has not been declared" "T" }
-  // { dg-error "declaration of 'template<int X> struct A::X'" "A::X" { target *-*-* } 5 }
-  // { dg-error "shadows template parm 'int X'" "shadow" { target *-*-* } 5 }
+  // { dg-error "declaration of 'template<int X> struct A::X' shadows" "A::X" { target *-*-* } 5 }
+  // { dg-message "template parameter 'X'" "" { target *-*-* } 5 }

I don't see any reason to check for specific diagnostics here; thelatter two messages are poor error-recovery, not something to test for.


OK with that change.

Jason

Follow-Ups:
- Re: [C++ Patch] Prefer error + inform to two errors in check_template_shadow
  - From: Paolo Carlini

References:
- [C++ Patch] Prefer error + inform to two errors in check_template_shadow
  - From: Paolo Carlini

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]