This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Remove duplicate graphite statistics printers

From: Jeff Law <law at redhat dot com>
To: Bernhard Reutner-Fischer <rep dot dot dot nop at gmail dot com>, gcc-patches at gcc dot gnu dot org
Cc: Daniel Berlin <dberlin at dberlin dot org>, Tobias Grosser <grosser at fim dot uni-passau dot de>, Sebastian Pop <sebpop at gmail dot com>
Date: Thu, 09 Jul 2015 11:50:00 -0600
Subject: Re: [PATCH] Remove duplicate graphite statistics printers
Authentication-results: sourceware.org; auth=none
References: <1436459431-14567-1-git-send-email-rep dot dot dot nop at gmail dot com> <559EA5E7 dot 2070402 at redhat dot com> <DF98281C-A9CE-4834-ADA5-51DF0E09A2C5 at gmail dot com>

On 07/09/2015 11:48 AM, Bernhard Reutner-Fischer wrote:

On July 9, 2015 6:48:39 PM GMT+02:00, Jeff Law <law@redhat.com> wrote:

On 07/09/2015 10:30 AM, Bernhard Reutner-Fischer wrote:


Thanks,

gcc/ChangeLog

2015-07-09  Bernhard Reutner-Fischer  <aldot@gcc.gnu.org>

	* graphite.h: New file.
	(print_graphite_statistics): Extern declaration.
	* graphite-scop-detection.c (print_graphite_scop_statistics,
	print_graphite_statistics): Remove.
	* graphite.c (print_graphite_statistics): Make public and add
	PREFIX parameter. Adjust callers.
	(print_graphite_scop_statistics): Add PREFIX parameter.

Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
---
-/* Print statistics for SCOPS to FILE.  */
+/* Print statistics for SCOPS to FILE. Prefix statistic headers with

PREFIX.  */
Nit.  Two spaces after a period, even in comments.


Done.

I wasn't sure where to put the prototype, maybe a graphite.h for just that (ATM) is not warranted?
Maybe an extern decl in graphite-scop-detection.c would be sufficient?

But it's more generic than that. I also wouldn't be surprised if wefound other things that belonged in graphite.h.


jeff

References:
- [PATCH] Remove duplicate graphite statistics printers
  - From: Bernhard Reutner-Fischer
- Re: [PATCH] Remove duplicate graphite statistics printers
  - From: Jeff Law
- Re: [PATCH] Remove duplicate graphite statistics printers
  - From: Bernhard Reutner-Fischer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]