This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR66794
- From: Richard Biener <rguenther at suse dot de>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 9 Jul 2015 09:46:07 +0200 (CEST)
- Subject: Re: [PATCH] Fix PR66794
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot LSU dot 2 dot 11 dot 1507081345060 dot 9923 at zhemvz dot fhfr dot qr> <CAMe9rOo9vi4m18G9xofqUmVxEjRUASv60YJF4pQntgawpJyc8w at mail dot gmail dot com>
On Wed, 8 Jul 2015, H.J. Lu wrote:
> On Wed, Jul 8, 2015 at 4:46 AM, Richard Biener <rguenther@suse.de> wrote:
> >
> > Passes do not expect post-dominators being around and thus forget
> > to invalidate them properly. Thus passes computing them have to
> > free them. The patch fixes path-isolation and adds an assert so
> > this doesn't happen again.
> >
> > Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk.
> >
> > Richard.
> >
> > 2015-07-08 Richard Biener <rguenther@suse.de>
> >
> > PR tree-optimization/66794
> > * passes.c (execute_function_todo): Assert that post-dominators
> > are not computed.
> > * gimple-ssa-isolate-paths.c (gimple_ssa_isolate_erroneous_paths):
> > Free post-dominators.
> >
>
> This caused:
>
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66807
Fixes as obvious with
2015-07-09 Richard Biener <rguenther@suse.de>
PR tree-optimization/66807
* tree-chkp-opt.c (chkp_opt_fini): Free post dominator info.
Index: gcc/tree-chkp-opt.c
===================================================================
--- gcc/tree-chkp-opt.c (revision 225546)
+++ gcc/tree-chkp-opt.c (working copy)
@@ -1282,6 +1282,8 @@ static void
chkp_opt_fini (void)
{
chkp_fix_cfg ();
+
+ free_dominance_info (CDI_POST_DOMINATORS);
}
/* Checker optimization pass function. */