This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Simplify signatures of std::list members: merge, splice, insert, erase

From: Jonathan Wakely <jwakely at redhat dot com>
To: libstdc++ at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
Date: Wed, 8 Jul 2015 13:18:27 +0100
Subject: Re: [patch] Simplify signatures of std::list members: merge, splice, insert, erase
Authentication-results: sourceware.org; auth=none
References: <20150708120042 dot GM13663 at redhat dot com>

On 08/07/15 13:00 +0100, Jonathan Wakely wrote:

patch2.txt then does the same thing for splice(), introducing a
__const_iterator typedef [3] to make the signatures consistent for
different language modes.

I think this makes the code more maintainable, as there are fewer #if
blocks with subtly different signatures.

Any objections to this one too, including doing the same for debug
mode and profile mode?


Oops, I only tested the first patch, and the second one was a bit
over-eager and changed a return type unintentionally.

Here's the working (tested) version of the second patch.

Attachment: patch2.txt
Description: Text document

References:
- [patch] Simplify signatures of std::list members: merge, splice, insert, erase
  - From: Jonathan Wakely

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]