This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Graphite cannot handle return stmt

From: Tobias Grosser <tobias at grosser dot es>
To: Sebastian Pop <sebpop at gmail dot com>, Aditya Kumar <hiraditya at msn dot com>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Tue, 30 Jun 2015 08:12:43 +0200
Subject: Re: [PATCH] Graphite cannot handle return stmt
Authentication-results: sourceware.org; auth=none
References: <1435611532-31080-1-git-send-email-hiraditya at msn dot com> <CAFk3UF9B1N9qkEvWf8EmjQfJso6WFk+_YpqyTf+HVmyTqDf1-g at mail dot gmail dot com>

On 06/30/2015 02:12 AM, Sebastian Pop wrote:

On Mon, Jun 29, 2015 at 3:58 PM, Aditya Kumar <hiraditya@msn.com> wrote:

No regressions.

2015-06-29  Aditya Kumar  <aditya.k7@samsung.com>
             Sebastian Pop <s.pop@samsung.com>

         * graphite-scop-detection.c (stmt_simple_for_scop_p): Bail out in case of a return statement.


Looks good to me.
Tobi, do you see a good reason not to cut scops at return stmts?

Return stmts in a SCoP are definitely invalid. Now, as in my last email,I wonder why this is not a positive list. There are probably a lot ofgimple codes that are invalid inside scops. By default we should refuseeverything we do _not_ know.


Best,
Tobias

Follow-Ups:
- Re: [PATCH] Graphite cannot handle return stmt
  - From: Richard Biener

References:
- [PATCH] Graphite cannot handle return stmt
  - From: Aditya Kumar
- Re: [PATCH] Graphite cannot handle return stmt
  - From: Sebastian Pop

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]