This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR c++/30044
- From: Patrick Palka <patrick at parcs dot ath dot cx>
- To: Jason Merrill <jason at redhat dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 23 Jun 2015 19:40:29 -0400
- Subject: Re: [PATCH] Fix PR c++/30044
- Authentication-results: sourceware.org; auth=none
- References: <1434072342-14126-1-git-send-email-patrick at parcs dot ath dot cx> <557F13E3 dot 3020507 at redhat dot com> <CA+C-WL9iT2Ab_360SYWmZVkRPWaz4scVQXLmWgi1Hp8cttzaOw at mail dot gmail dot com> <5588E2B1 dot 7010703 at redhat dot com>
On Tue, Jun 23, 2015 at 12:38 AM, Jason Merrill <jason@redhat.com> wrote:
> On 06/15/2015 02:32 PM, Patrick Palka wrote:
>>
>> On Mon, Jun 15, 2015 at 2:05 PM, Jason Merrill <jason@redhat.com> wrote:
>>>
>>> Any reason not to use grow_tree_vec?
>>
>>
>> Doing so causes a lot of ICEs in the testsuite. I think it's because
>> grow_tree_vec invalidates the older parameter_vec which some trees may
>> still be holding a reference to in their DECL_TEMPLATE_PARMS field.
>
>
> Hmm, that's unfortunate, as doing it this way means we get a bunch of
> garbage TREE_VECs in the process. But I guess the patch is OK as is.
Yeah, though I can't think of a simple way to work around this -- any
solution I think of seems to require a change in the representation of
current_template_parms, something that would be quite invasive....
Will commit the patch shortly.
>
> Jason
>