This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Fix verify_type ICE with -fshort-enum
- From: Marek Polacek <polacek at redhat dot com>
- To: Jan Hubicka <hubicka at ucw dot cz>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Fri, 12 Jun 2015 10:00:38 +0200
- Subject: Re: Fix verify_type ICE with -fshort-enum
- Authentication-results: sourceware.org; auth=none
- References: <20150611214743 dot GA59435 at kam dot mff dot cuni dot cz>
On Thu, Jun 11, 2015 at 11:47:43PM +0200, Jan Hubicka wrote:
> Hi,
> gcc.c-torture/execute/930408-1.c currently ICE on -fshort-enum target(s) because
> TYPE_PACKED is not consistently set among type variants.
I guess that's because of the forward declaration in the test. But I have
no access to an ARM machine, so can't verify.
> Bootstrapped/regtested ppc64le-linux, OK?
> Honza
>
> PR middle-end/66325
> * c-decl.c (start_enum): Set TYPE_PACKED consistently among type variants.
> Index: c-decl.c
> ===================================================================
> --- c-decl.c (revision 224250)
> +++ c-decl.c (working copy)
> @@ -7946,7 +7946,8 @@
> the_enum->enum_overflow = 0;
>
> if (flag_short_enums)
> - TYPE_PACKED (enumtype) = 1;
> + for (tree v = TYPE_MAIN_VARIANT (enumtype); v ;v = TYPE_NEXT_VARIANT (v))
Please fix the formatting here: no space before ;.
Ok with that change.
Marek