This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Adjust gcc-plugin.h
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: Andrew MacLeod <amacleod at redhat dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 9 Jun 2015 14:34:55 +0200
- Subject: Re: [patch] Adjust gcc-plugin.h
- Authentication-results: sourceware.org; auth=none
- References: <55758574 dot 7070104 at redhat dot com> <CAFiYyc1DLJMZ=8En6JuxA3pEUnwUawtwSfw2QQuZ7VAn0H6w7w at mail dot gmail dot com> <5575D64A dot 1020102 at redhat dot com> <CAFiYyc10eJO32o=EN5ctLhg6ZX_MN2HxqiHtm56G7zPjtMLFgQ at mail dot gmail dot com> <5576DCD7 dot 3040309 at redhat dot com>
On Tue, Jun 9, 2015 at 2:32 PM, Andrew MacLeod <amacleod@redhat.com> wrote:
> On 06/09/2015 03:56 AM, Richard Biener wrote:
>>
>> On Mon, Jun 8, 2015 at 7:52 PM, Andrew MacLeod <amacleod@redhat.com>
>> wrote:
>>>
>>>
>>> the gcc source files need to see the internal bits in plugin.h, as well
>>> as
>>> the common decls in gcc-plugin.h. So we could change the includes as you
>>> suggest, but we'd have to copy all the decls from gcc-inlcude.h to
>>> plugin.h
>>> so the gcc functions can see them. And then the plugins would be exposed
>>> to
>>> all the internal APIs and decls present in plugins.h
>>
>> plugins are exposed to all internals of GCC anyway. gcc-plugin.h should
>> really
>> just be a #include kitchen-sink.
>>
>>
>>> Im presuming
>>> we didnt want to do that and thats why there were 2 files to start with.
>>
>> No, gcc-plugin.h was introduced to make the set of includes required
>> for plugins "stable".
>>
>> Richard.
>>
>>
> I didn't actually realize that.. at least its serving its true purpose now
> :-)
>
> So hows this. Bootstrapping and testruns proceeding now, but it should have
> the same results as the other patch.
> Assuming no regressions, OK?
Ok.
Richard.
> Andrew
>
>
>