This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 01/13] recog: Increased max number of alternatives - v2
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Andreas Krebbel <krebbel at linux dot vnet dot ibm dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 8 Jun 2015 15:38:03 +0200
- Subject: Re: [PATCH 01/13] recog: Increased max number of alternatives - v2
- Authentication-results: sourceware.org; auth=none
- References: <1431350621-21405-1-git-send-email-krebbel at linux dot vnet dot ibm dot com> <1431350621-21405-2-git-send-email-krebbel at linux dot vnet dot ibm dot com> <5559EBF8 dot 3050003 at linux dot vnet dot ibm dot com> <CAFiYyc3o-=Jtqm2Doo4BScw6RS-sH-GGbN4=FORBAkgKGJr4pQ at mail dot gmail dot com> <555AF6FA dot 4040408 at linux dot vnet dot ibm dot com> <20150522075400 dot GA17341 at maggie> <20150601082201 dot GG10247 at tucnak dot redhat dot com> <55759982 dot 4090402 at linux dot vnet dot ibm dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Mon, Jun 08, 2015 at 03:32:50PM +0200, Andreas Krebbel wrote:
> On 06/01/2015 10:22 AM, Jakub Jelinek wrote:
> > On Fri, May 22, 2015 at 09:54:00AM +0200, Andreas Krebbel wrote:
> >> On Tue, May 19, 2015 at 10:40:26AM +0200, Andreas Krebbel wrote:
> >>> On 05/18/2015 04:19 PM, Richard Biener wrote:
> >>>> Please use uint64_t instead.
> >>>
> >>> Done. Ok with that change?
> >>
> >> I've applied the following patch.
> >
> > Note that on current trunk cross compiler from x86_64-linux to
> > s390x-linux (admittedly just make cc1 of an older configured tree,
> > but with libcpp (normal and build) rebuilt) fails miserably with
> > genattrtab: invalid alternative specified for pattern number 1015
> >
> >> * recog.h: Increase MAX_RECOG_ALTERNATIVES.
> >> Change type of alternative_mask to uint64_t.
> >
> > From quick look at genattrtab.c, there are many further spots
> > which rely on MAX_RECOG_ALTERNATIVES fitting into int bits.
> >
> > With this quick patch make cc1 at least succeeds, but no idea whether
> > I've caught all the spots which work with bitmasks of alternatives.
>
> I've regtested your patch on S/390 without seeing any problems. Could you please commit it to mainline?
Ok, I will. Have you looked around if these are all the spots
that need changing for this in the gen* tools?
Perhaps trying -fsanitize=undefined and/or valgrind. I admit I haven't
spent too much time on it.
Jakub