This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] 65479 - sanitizer stack trace missing frames past #0 on powerpc64

From: Jeff Law <law at redhat dot com>
To: Martin Sebor <msebor at redhat dot com>, Jakub Jelinek <jakub at redhat dot com>, Yury Gribov <y dot gribov at samsung dot com>
Cc: Gcc Patch List <gcc-patches at gcc dot gnu dot org>
Date: Wed, 03 Jun 2015 07:56:32 -0600
Subject: Re: [PATCH] 65479 - sanitizer stack trace missing frames past #0 on powerpc64
Authentication-results: sourceware.org; auth=none
References: <55345AD3 dot 3000403 at redhat dot com> <5535441A dot 4030200 at redhat dot com> <55357E7C dot 9090000 at redhat dot com> <555CB18A dot 1020205 at redhat dot com> <555D1255 dot 9010406 at redhat dot com>

On 05/20/2015 05:01 PM, Martin Sebor wrote:

Now that I know a bit more from Jakub & Yuri's comments, I don't think


I opened compiler_rt/23600 and attached the sanitizer patch
to it:

   http://llvm.org/bugs/show_bug.cgi?id=23600

If there are no objections to the bug I'll post the patch for
review next.

Thanks. Seems to be moving along. Looks like they were a bit surprisedthat you'd included a patch ;-)

So I'll ask the question(s) in a slightly different way and see if that
guides us one direction or another.

Do the libbacktrace changes make sense independently?  ie, are they the
right thing to do, even if they don't fix a visible bug?  ISTM the
answer to both questions is yes.  In which case, that part ought to go
forward now rather than waiting.


Yes. They fix the sort stability bug. The bug can be reproduced
without any ASan patches by compiling the ASan tests on powerpc64
with the -fasynchronous-unwind-tables option. It's also possible
that the bug can be reproduced with other programs on other
targets. It's just not triggered by the same tests on the targets
we commonly test.

OK.  You can go ahead and commit the libbacktrace fix.

Let's hold off on the testsuite fixes until we've got the sanitizer &libbacktrace fixes installed.


jeff

Follow-Ups:
- Re: [PATCH] 65479 - sanitizer stack trace missing frames past #0 on powerpc64
  - From: Martin Sebor

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]