This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR65549, avoid force_decl_die in late compilation
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: Richard Biener <rguenther at suse dot de>
- Cc: Jakub Jelinek <jakub at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Jason Merrill <jason at redhat dot com>
- Date: Mon, 1 Jun 2015 12:39:56 +0200
- Subject: Re: [PATCH] Fix PR65549, avoid force_decl_die in late compilation
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot LSU dot 2 dot 11 dot 1504171053060 dot 6786 at zhemvz dot fhfr dot qr> <alpine dot LSU dot 2 dot 11 dot 1504171229240 dot 6786 at zhemvz dot fhfr dot qr> <20150417103907 dot GK1725 at tucnak dot redhat dot com> <alpine dot LSU dot 2 dot 11 dot 1504281036590 dot 20496 at zhemvz dot fhfr dot qr>
On Tue, Apr 28, 2015 at 10:37 AM, Richard Biener <rguenther@suse.de> wrote:
> On Fri, 17 Apr 2015, Jakub Jelinek wrote:
>
>> On Fri, Apr 17, 2015 at 12:32:03PM +0200, Richard Biener wrote:
>> > So Jakub says that using comp_unit_die () for the context of the stub
>> > DIE is wrong and he is of course right. The following adjusted patch
>> > uses the correct context, but only if we already have a DIE for it,
>> > otherwise we drop the DW_TAG_GNU_call_site ref on the floor.
>>
>> I'd mention that this last line doesn't match what the code does,
>> because in reality it just means that we drop the DW_AT_abstract_origin
>> of DW_TAG_GNU_call_site. That really means just that the debugger won't
>> know what function is called at that point, as if it were e.g.
>> an indirect jump with unknown target that is not preserved in any register
>> across the call), but e.g. all the guarantees that we cover all the calls
>> still holds.
>
> Ping.
Ping again - I'd really like to fix this most-common LTO ICE on the 4.8 branch.
I'm fine with guarding all the code with in_lto_p if you require me to do that.
So - any further guidance please?
For reference, the last patch was at
https://gcc.gnu.org/ml/gcc-patches/2015-04/msg00862.html
Thanks,
Richard.
> Richard.