This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, x86, libgomp, libitm]: Remove __PIC__ versions of syscall
- From: Uros Bizjak <ubizjak at gmail dot com>
- To: Richard Henderson <rth at redhat dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Jakub Jelinek <jakub at redhat dot com>
- Date: Wed, 27 May 2015 22:26:01 +0200
- Subject: Re: [PATCH, x86, libgomp, libitm]: Remove __PIC__ versions of syscall
- Authentication-results: sourceware.org; auth=none
- References: <CAFULd4ZqOvnp=qY9q+nD9myvhRLi7SpE+n2GYwuHCWWF7r6fBQ at mail dot gmail dot com> <5566246D dot 1040701 at redhat dot com>
On Wed, May 27, 2015 at 10:09 PM, Richard Henderson <rth@redhat.com> wrote:
> On 05/27/2015 12:40 PM, Uros Bizjak wrote:
>> Also, fix function operand type to match the operand type.
>
> Why do you believe op to be of type "long"?
> Certainly man 2 futex doesn't say that.
In libgomp/config/linux/wait.h, we have:
extern long int gomp_futex_wait, gomp_futex_wake;
These are passed in libgomp/config/linux/x86/futex.h as:
long res = sys_futex0 (addr, gomp_futex_wait, val);
Considering that x86 is an ILP32 target, and looking at x86_64's
sys_futex0 in libitm/config/linux/x86 I choose long here. If we want
to follow futex manpage, we probably need to redefine gomp_futex_wait
and gomp_futex_wake as a plain int.
Uros.