This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch, testsuite] don't specify "dg-do run" explicitly for vect test cases


On 05/21/2015 03:08 AM, Richard Biener wrote:
On Thu, May 21, 2015 at 7:12 AM, Sandra Loosemore
<sandra@codesourcery.com> wrote:
On targets such as ARM, some arches are compatible with options needed to
enable compilation with vectorization, but the specific hardware (or
simulator or BSP) available for execution tests may not implement or enable
those features.  The vect.exp test harness already includes some magic to
determine whether the target hw can execute vectorized code and sets
dg-do-what-default to compile the tests only if they can't be executed.
It's a mistake for individual tests to explicitly say "dg-do run" because
this overrides the harness's magic default and forces the test to be
executed, even if doing so just ends up wedging the target.

I already committed two patches last fall (r215627 and r218427) to address
this, but people keep adding new vect test cases with the same problem, so
here is yet another installment to clean them up.  I tested this on
arm-none-eabi with a fairly large collection of multilibs.  OK to commit?

Huh... I thought we have the check_vect () stuff for that...?

We do; this is what sets dg-do-what-default. But, if the test case specifies dg-do whatever explicitly, that overrides the default. So, don't do that! :-P

-Sandra


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]