This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] -Wmisleading-indentation: Increase test coverage


On 05/20/2015 09:43 AM, David Malcolm wrote:
Add various new tests to Wmisleading-indentation.c:

   * Ensure that users can use pragma to turn off
     -Wmisleading-indentation for a range of code.

   * Add functions demonstrating a variety of indentation styles
     seen:

       (a) on http://en.wikipedia.org/wiki/Indent_style

       (b) via the manpage of GNU "indent"

     to verify that -Wmisleading-indentation doesn't emit false
     positives for these.

Tested with:

   make check-gcc RUNTESTFLAGS="-v -v dg.exp=Wmisleading-indentation.c"
   # of expected passes 42

   make check-g++ RUNTESTFLAGS="-v -v dg.exp=Wmisleading-indentation.c"
   # of expected passes		126

In both cases, the # of expected passes remained unchanged, and no new
fails were reported.

OK for trunk?

gcc/testsuite/ChangeLog:
	* c-c++-common/Wmisleading-indentation.c (fn_32): New.
	(fn_33_k_and_r_style): New.
	(fn_33_stroustrup_style): New.
	(fn_33_allman_style): New.
	(fn_33_whitesmiths_style): New.
	(fn_33_horstmann_style): New.
	(fn_33_ratliff_banner_style): New.
	(fn_33_lisp_style): New.
	(fn_34_indent_dash_gnu): New.
	(fn_34_indent_dash_kr): New.
	(fn_34_indent_dash_orig): New.
	(fn_34_indent_linux_style): New.
OK.
jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]