This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [AArch64][PR65375] Fix RTX cost for vector SET
- From: Kugan <kugan dot vivekanandarajah at linaro dot org>
- To: James Greenhalgh <james dot greenhalgh at arm dot com>
- Cc: Kyrylo Tkachov <Kyrylo dot Tkachov at arm dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, Jim Wilson <jim dot wilson at linaro dot org>
- Date: Wed, 20 May 2015 13:08:28 +1000
- Subject: Re: [AArch64][PR65375] Fix RTX cost for vector SET
- Authentication-results: sourceware.org; auth=none
- References: <552D8FF7 dot 5000105 at linaro dot org> <20150415092509 dot GA20852 at arm dot com> <552E4150 dot 3020403 at linaro dot org> <20150415111854 dot GB22143 at arm dot com> <552E4C90 dot 4070208 at linaro dot org> <5530EC32 dot 4030806 at linaro dot org> <20150420202225 dot GA7414 at arm dot com> <553AD118 dot 3010705 at linaro dot org> <20150505061726 dot GA31362 at arm dot com> <55497891 dot 4010801 at linaro dot org> <20150507072446 dot GA27987 at arm dot com>
On 07/05/15 17:24, James Greenhalgh wrote:
> On Wed, May 06, 2015 at 03:12:33AM +0100, Kugan wrote:
>>>> gcc/ChangeLog:
>>>>
>>>> 2015-04-24 Kugan Vivekanandarajah <kuganv@linaro.org>
>>>> Jim Wilson <jim.wilson@linaro.org>
>>>>
>>>> * config/arm/aarch-common-protos.h (struct mem_cost_table): Added
>>>> new fields loadv and storev.
>>>> * config/aarch64/aarch64-cost-tables.h (thunderx_extra_costs):
>>>> Initialize loadv and storev.
>>>> * config/arm/aarch-cost-tables.h (generic_extra_costs): Likewise.
>>>> (cortexa53_extra_costs): Likewise.
>>>> (cortexa57_extra_costs): Likewise.
>>>> (xgene1_extra_costs): Likewise.
>>>> * config/aarch64/aarch64.c (aarch64_rtx_costs): Update vector
>>>> rtx_costs.
>>
>> Thanks James for the review. Attached patch changes this. Is this OK ?
>
> Hi Kugan,
>
> Thanks for sticking with it through a long review, sorry that the replies
> have been patchy, I'm still travelling.
>
> This patch is OK for trunk, with an updated ChangeLog and assuming no
> regressions after a test run (And a quick check with some popular
> benchmarks if possible)
Committed as r223432 after fresh bootstrap and spec2k benchmarking.
Thanks,
Kugan