This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 5/4] libcpp: Eliminate most of the non-const/reference-returning inline fns

From: Jeff Law <law at redhat dot com>
To: David Malcolm <dmalcolm at redhat dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Fri, 08 May 2015 15:48:57 -0600
Subject: Re: [PATCH 5/4] libcpp: Eliminate most of the non-const/reference-returning inline fns
Authentication-results: sourceware.org; auth=none
References: <5547C538 dot 5000606 at redhat dot com> <1430850074-40522-1-git-send-email-dmalcolm at redhat dot com> <1430850074-40522-4-git-send-email-dmalcolm at redhat dot com>

On 05/05/2015 12:21 PM, David Malcolm wrote:

gcc/java/ChangeLog:
	* jcf-parse.c (set_source_filename): Replace write through
	ORDINARY_MAP_FILE_NAME with direct access to "to_file".

libcpp/ChangeLog:
	* include/line-map.h (MAP_START_LOCATION): Eliminate the non-const
	variant, and tweak comment for the const variant.
	(ORDINARY_MAP_STARTING_LINE_NUMBER): Drop the non-const variant.
	(ORDINARY_MAP_INCLUDER_FILE_INDEX): Likewise.
	(ORDINARY_MAP_IN_SYSTEM_HEADER_P): Likewise.
	(SET_ORDINARY_MAP_NUMBER_OF_COLUMN_BITS): Delete.
	(ORDINARY_MAP_FILE_NAME): Drop the non-const variant.
	(MACRO_MAP_MACRO): Likewise.
	(MACRO_MAP_NUM_MACRO_TOKENS): Likewise.
	(MACRO_MAP_LOCATIONS): Likewise.
	(MACRO_MAP_EXPANSION_POINT_LOCATION): Likewise.
	* line-map.c (linemap_add): Replace writes through macros with
	direct field accesses.
	(linemap_enter_macro): Likewise.
	(linemap_line_start): Likewise.

OK.
jeff

References:
- Re: [PATCH 2/4] libcpp: Replace macro usage with C++ constructs
  - From: Jeff Law
- [PATCH 2/4 v2] libcpp: Replace macro usage with C++ constructs)
  - From: David Malcolm
- [PATCH 5/4] libcpp: Eliminate most of the non-const/reference-returning inline fns
  - From: David Malcolm

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]