This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix ubsan non-call-exceptions ICE (PR tree-optimization/65984)

From: Jeff Law <law at redhat dot com>
To: Jakub Jelinek <jakub at redhat dot com>, Richard Biener <rguenther at suse dot de>
Cc: gcc-patches at gcc dot gnu dot org
Date: Mon, 04 May 2015 13:43:09 -0600
Subject: Re: [PATCH] Fix ubsan non-call-exceptions ICE (PR tree-optimization/65984)
Authentication-results: sourceware.org; auth=none
References: <20150504181640 dot GF1751 at tucnak dot redhat dot com>

On 05/04/2015 12:16 PM, Jakub Jelinek wrote:

Hi!

The code I've added in r217755 was assuming that stmt_could_throw_p
memory read will always end a bb, but that is clearly not the case.
Thus, the following patch uses stmt_ends_bb_p instead.

Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk/5?

2015-05-04  Jakub Jelinek  <jakub@redhat.com>

	PR tree-optimization/65984
	* ubsan.c: Include tree-cfg.h.
	(instrument_bool_enum_load): Use stmt_ends_bb_p instead of
	stmt_could_throw_p test, rename can_throw variable to ends_bb.

	* c-c++-common/ubsan/pr65984.c: New test.

OK.
Jeff

References:
- [PATCH] Fix ubsan non-call-exceptions ICE (PR tree-optimization/65984)
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]