Re: [PATCH, AArch64] Add Cortex-A53 erratum 843419 configure-time option

[Yvan Roux <yvan dot roux at linaro dot org>]

Hi Marcus,

On 1 May 2015 at 17:18, Marcus Shawcroft <marcus.shawcroft@gmail.com> wrote:
> On 1 May 2015 at 14:56, Yvan Roux <yvan.roux@linaro.org> wrote:
>
>> 2015-05-01  Yvan Roux  <yvan.roux@linaro.org>
>>
>>      * configure.ac: Add --enable-fix-cortex-a53-843419 option.
>>      * configure: Regenerate.
>>      * config/aarch64/aarch64-elf-raw.h (CA53_ERR_843419_SPEC): Define.
>>      (LINK_SPEC): Include CA53_ERR_843419_SPEC.
>>      * config/aarch64/aarch64-linux.h (CA53_ERR_843419_SPEC): Define.
>>      (LINK_SPEC): Include CA53_ERR_843419_SPEC.
>>      * doc/install.texi (aarch64*-*-*): Document
>>      new --enable-fix-cortex-a53-843419 option
>>      * config/aarch64/aarch64.opt (mfix-cortex-a53-843419): New option.
>>      * doc/invoke.texi (AArch64 Options): Document -mfix-cortex-a53-843419
>>      and -mno-fix-cortex-a53-8434199 options.
>>
>
> +@option{--enable-fix-cortex-a53-843419} option.  This erratum
> workaround is
> +made at link time and enabling it by default in GCC will only pass
> the
>
> How about something like "The workaround is applied at link time.
> Enabling the workaround will cause GCC to pass the relevant option to
> the linker." ?

Yes this is a better formulation.

> +corresponding flag to the linker.  It can be explicitly disabled
> during
> +compilation by passing the @option{-mno-fix-cortex-a53-835769} option.
>
> Copy paste error here with the previous errata number.

Here is the patch with the modifications.  Is it needed to backport it
into 4.9 and 5.1 branches ?

Cheers,
Yvan

Attachment: erratum-843419-3.diff
Description: Text document