This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][AArch64] Make aarch64_min_divisions_for_recip_mul configurable
- From: Marcus Shawcroft <marcus dot shawcroft at gmail dot com>
- To: Wilco Dijkstra <wdijkstr at arm dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 1 May 2015 13:17:53 +0100
- Subject: Re: [PATCH][AArch64] Make aarch64_min_divisions_for_recip_mul configurable
- Authentication-results: sourceware.org; auth=none
- References: <000401d080f0$16a78c90$43f6a5b0$ at com> <CAFqB+PzAUb=bFjhRpQwD9WaFfnL-jVuvUaRqig=khKP2oeffPQ at mail dot gmail dot com> <000001d08401$abe1a570$03a4f050$ at com>
On 1 May 2015 at 12:26, Wilco Dijkstra <wdijkstr@arm.com> wrote:
>
>
>> Marcus Shawcroft wrote:
>> On 27 April 2015 at 14:43, Wilco Dijkstra <wdijkstr@arm.com> wrote:
>>
>> >> static unsigned int
>> >> -aarch64_min_divisions_for_recip_mul (enum machine_mode mode ATTRIBUTE_UNUSED)
>> >> +aarch64_min_divisions_for_recip_mul (enum machine_mode mode)
>> >> {
>> >> - return 2;
>> >> + if (GET_MODE_UNIT_SIZE (mode) == 4)
>> >> + return aarch64_tune_params->min_div_recip_mul_sf;
>> >> + return aarch64_tune_params->min_div_recip_mul_df;
>>
>> This should be expressed directly as mode == SFmode (or DFmode) rather
>> than the indirect approach of first computing the size first.
>
> Can we never see vector types at this point?
Fair point, curiously we don't appear to see them, but I see no reason
why we should not. Commit your patch as proposed.
Cheers /Marcus