This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix for PR26702: Emit .size for BSS variables on arm-eabi
- From: "Bin.Cheng" <amker dot cheng at gmail dot com>
- To: ramrad01 at arm dot com
- Cc: Kwok Cheung Yeung <kcy at codesourcery dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 30 Apr 2015 15:13:50 +0800
- Subject: Re: [PATCH] Fix for PR26702: Emit .size for BSS variables on arm-eabi
- Authentication-results: sourceware.org; auth=none
- References: <5519B12F dot 6000508 at codesourcery dot com> <CAJA7tRaeLY9iGfL6AFpMEZE=Jbw+nYU1ouLFN6jBa58f=ruQ6Q at mail dot gmail dot com>
On Thu, Apr 23, 2015 at 10:51 PM, Ramana Radhakrishnan
<ramana.gcc@googlemail.com> wrote:
> On Mon, Mar 30, 2015 at 9:25 PM, Kwok Cheung Yeung <kcy@codesourcery.com> wrote:
>> This is a simple patch that ensures that a .size directive is emitted when
>> space is allocated for a static variable in the BSS on bare-metal ARM
>> targets. This allows other tools such as GDB to look up the size of the
>> object correctly.
>>
>> Before:
>>
>> $ readelf -s pr26702.o
>>
>> Symbol table '.symtab' contains 10 entries:
>> Num: Value Size Type Bind Vis Ndx Name
>> ...
>> 6: 00000000 0 NOTYPE LOCAL DEFAULT 3 static_foo
>> ...
>>
>> After:
>>
>> $ readelf -s pr26702.o
>>
>> Symbol table '.symtab' contains 10 entries:
>> Num: Value Size Type Bind Vis Ndx Name
>> ...
>> 6: 00000000 4 NOTYPE LOCAL DEFAULT 3 static_foo
>> ...
>>
>> The testsuite has been run with a i686-pc-linux-gnu hosted cross-compiler
>> targetted at arm-none-eabi with no regressions.
>>
>> Kwok
>>
>>
>> 2015-03-30 Kwok Cheung Yeung <kcy@codesourcery.com>
>>
>> gcc/
>> PR target/26702
>> * config/arm/unknown-elf.h (ASM_OUTPUT_ALIGNED_DECL_LOCAL): Emit
>> size of local.
>>
>> gcc/testsuite/
>> PR target/26702
>> * gcc.target/arm/pr26702.c: New test.
>>
>> Index: gcc/testsuite/gcc.target/arm/pr26702.c
>> ===================================================================
>> --- gcc/testsuite/gcc.target/arm/pr26702.c (revision 0)
>> +++ gcc/testsuite/gcc.target/arm/pr26702.c (revision 0)
>> @@ -0,0 +1,4 @@
>> +/* { dg-do compile { target arm*-*-eabi* } } */
>> +/* { dg-final { scan-assembler "\\.size\[\\t \]+static_foo, 4" } } */
>> +int foo;
>> +static int static_foo;
>> Index: gcc/config/arm/unknown-elf.h
>> ===================================================================
>> --- gcc/config/arm/unknown-elf.h (revision 447549)
>> +++ gcc/config/arm/unknown-elf.h (working copy)
>> @@ -81,6 +81,8 @@
>> ASM_OUTPUT_ALIGN (FILE, floor_log2 (ALIGN / BITS_PER_UNIT)); \
>> ASM_OUTPUT_LABEL (FILE, NAME); \
>> fprintf (FILE, "\t.space\t%d\n", SIZE ? (int)(SIZE) : 1);
>> \
>> + fprintf (FILE, "\t.size\t%s, %d\n", \
>> + NAME, SIZE ? (int)(SIZE) : 1); \
>> } \
>> while (0)
>>
>
>
> Now applied as attached with the following modifications.
>
> Sorry about the delay - I've been away for a bit and couldn't attend
> to committing this.
Hi Kwok,
The newly introduced test case failed on
arm-none-linux-gnueabi&arm-none-linux-gnueabihf. Could you please
have a look at it?
FAIL: gcc.target/arm/pr26702.c scan-assembler \\.size[\\t ]+static_foo, 4
PR65937 is filed for tracking this.
Thanks,
bin
>
> Thanks
> Ramana