This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix size & type for cold partition names (hot-cold function partitioning)
- From: Uros Bizjak <ubizjak at gmail dot com>
- To: Caroline Tice <cmtice at google dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Jeff Law <law at redhat dot com>, Richard Henderson <rth at redhat dot com>
- Date: Thu, 30 Apr 2015 08:12:22 +0200
- Subject: Re: [PATCH] Fix size & type for cold partition names (hot-cold function partitioning)
- Authentication-results: sourceware.org; auth=none
- References: <CAFULd4anFuykMh6ZmDhJ7QM_5enEpR=1p=S5n5gRgcHHpR1zmA at mail dot gmail dot com> <CABtf2+Q-fqDMUwCBY5WdoRYnyOh+MOB9G8HQh9+e3U_wHRjpoQ at mail dot gmail dot com> <CAFULd4b9B5LD1khwkefwnLfarjJMMTayS=_uxaheiXPhjGj3CQ at mail dot gmail dot com> <CAFULd4Y4KnrkzuSKxsdkmHuMmZ-qzQvjR80BB44AP-SEiq=RLQ at mail dot gmail dot com> <CABtf2+Rnjp7f+wHUpn_E2dti-CkYTMk28puyH-EL1=5ep-brKA at mail dot gmail dot com> <CABtf2+TqLWgJr5od3pETcV3W7ZQ7-sm9zQXjVc6z0MBhGwGuZQ at mail dot gmail dot com>
On Wed, Apr 29, 2015 at 11:22 PM, Caroline Tice <cmtice@google.com> wrote:
> Here is a new patch to update the cold name partition so that it will
> only be treated like a function name and be given a size on the
> architectures that specifically define macros for such.
>
> I also updated the test case to try to only test on the appropriate
> architectures. I am not sure I got the target triples correct for
> this, so I would appreciate some extra attention to that in the
> review. I have tested this new patch on my workstation and it works
> as intended. I am in the process of bootstrapping with the new patch.
> Assuming that the bootstrap passes, is this ok to commit?
>
> -- Caroline Tice
> cmtice@google.com
>
> ChangeLog (gcc):
>
> 2015-04-29 Caroline Tice <cmtice@google.com>
>
> PR 65929
> * config/elfos.h (ASM_DECLARE_COLD_FUNCTION_NAME): New macro definition.
> (ASM_DECLARE_COLD_FUNCTION_SIZE): New macro definition.
> * final.c (final_scan_insn): Use ASM_DECLARE_COLD_FUNCTION_NAME
> instead of ASM_DECLARE_FUNCTION_NAME for cold partition name.
> * varasm.c (assemble_end_function): Use ASM_DECLARE_COLD_FUNCTION_SIZE
> instead of ASM_DECLARE_FUNCTION_SIZE for cold partition size.
>
> ChangeLog (testsuite):
>
> 2015-04-29 Caroline Tice <cmtice@google.com>
>
> PR 65929
> * gcc.dg/tree-prof/cold_partition_label.c: Only check for cold
> partition size on certain targets.
Documentation for new macros is missing (please see doc/tm.texi.in).
Uros.