This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RE: [RFC: Patch, PR 60158] gcc/varasm.c : Pass actual alignment value to output_constant_pool_2
- From: "rohitarulraj at freescale dot com" <rohitarulraj at freescale dot com>
- To: Jeff Law <law at redhat dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "rguenther at suse dot de" <rguenther at suse dot de>, "Jakub Jelinek" <jakub at redhat dot com>
- Cc: Alan Modra <amodra at gmail dot com>, David Edelsohn <dje dot gcc at gmail dot com>, "Edmar Wienskoski" <edmar at freescale dot com>, "rohitarulraj at freescale dot com" <rohitarulraj at freescale dot com>
- Date: Tue, 28 Apr 2015 18:38:48 +0000
- Subject: RE: [RFC: Patch, PR 60158] gcc/varasm.c : Pass actual alignment value to output_constant_pool_2
- Authentication-results: sourceware.org; auth=none
- Authentication-results: redhat.com; dkim=none (message not signed) header.d=none;
- References: <BLUPR03MB14584D4240675B763002EA5FC2090 at BLUPR03MB1458 dot namprd03 dot prod dot outlook dot com> <BLUPR03MB1458002E9FF7B37BD72093E5C2E80 at BLUPR03MB1458 dot namprd03 dot prod dot outlook dot com> <553FCEC6 dot 8030609 at redhat dot com>
>-----Original Message-----
>From: Jeff Law [mailto:law@redhat.com]
>Sent: Tuesday, April 28, 2015 11:48 PM
>To: Dharmakan Rohit-B30502; gcc-patches@gcc.gnu.org; rguenther@suse.de; Jakub Jelinek
>Cc: Alan Modra; David Edelsohn; Wienskoski Edmar-RA8797
>Subject: Re: [RFC: Patch, PR 60158] gcc/varasm.c : Pass actual alignment value to output_constant_pool_2
>
>On 04/28/2015 03:44 AM, rohitarulraj@freescale.com wrote:
>> Ping.
>>
>> -----Original Message-----
>> From: Dharmakan Rohit-B30502
>> Sent: Friday, March 27, 2015 7:57 PM
>> To: gcc-patches@gcc.gnu.org; rguenther@suse.de; Jakub Jelinek
>> Cc: Alan Modra; David Edelsohn; Wienskoski Edmar-RA8797; Dharmakan Rohit-B30502
> >Subject: RE: [RFC: Patch, PR 60158] gcc/varasm.c : Pass actual alignment value to output_constant_pool_2
>>
>> Hi,
>>
>> I would like to resubmit these patches for comments. The previous detailed discussion is available in the below mentioned link.
>> https://gcc.gnu.org/ml/gcc-patches/2014-04/msg01679.html
>> https://gcc.gnu.org/ml/gcc-patches/2014-05/msg00489.html
>>
>> The issue is still reproducible on GCC v4.8 branch.
>>
>> I have tested both the attached patches with e500v2 tool chain on GCC v4.8 branch [rev 221667] and GCC trunk [rev 221310] with no regressions.
>>
>> Patch1 [gcc.fix_pr60158_fixup_table_fsf_1]: Pass actual alignment value to output_constant_pool_2.
>> Patch2 [gcc.fix_pr60158_fixup_table_fsf_2]: Use the alignment data available in the first argument (constant_descriptor_rtx) of output_constant_pool_1.
>> (Note: this generates ".align" directive twice).
>Are you asking for both patches to be applied or just one?
Just one, needed your comments on which would be better.
Regards,
Rohit