This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Tidy up locking for libgomp OpenACC entry points
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Julian Brown <julian at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Thomas Schwinge <thomas at codesourcery dot com>
- Date: Thu, 23 Apr 2015 10:32:11 +0200
- Subject: Re: [PATCH] Tidy up locking for libgomp OpenACC entry points
- Authentication-results: sourceware.org; auth=none
- References: <20150422194243 dot 115f26fa at octopus>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, Apr 22, 2015 at 07:42:43PM +0100, Julian Brown wrote:
> @@ -120,25 +116,32 @@ acc_free (void *d)
> {
> splay_tree_key k;
> struct goacc_thread *thr = goacc_thread ();
> + struct gomp_device_descr *acc_dev = thr->dev;
IMHO you want to move this line after:
>
> if (!d)
> return;
>
> assert (thr && thr->dev);
the assert. Supposedly also the thr = line after the return; line,
no need to do it if returning early. As gcc now defaults to -std=gnu11
for C, libgomp is written in C11 and you don't need to limit to C89 (and
even back then, it was compiled by gcc and thus you could use GNU
extensions, such as mixed declarations and code).
Otherwise, I have no problem with this going to trunk, if Thomas is ok with
it.
Jakub