This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [committed] Fix GC ICE due to dwarf2out bug (PR debug/65807)
- From: Mike Stump <mikestump at comcast dot net>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 20 Apr 2015 11:49:46 -0700
- Subject: Re: [committed] Fix GC ICE due to dwarf2out bug (PR debug/65807)
- Authentication-results: sourceware.org; auth=none
- References: <20150420133425 dot GJ1725 at tucnak dot redhat dot com>
On Apr 20, 2015, at 6:34 AM, Jakub Jelinek <jakub@redhat.com> wrote:
> add_AT_wide is the only add_AT_* that doesn't clear or otherwise initialize
> dw_attr_val.val_entry field, so it contains random garbage, which isn't
> desirable when ggc walks it during collections.
>
> Supposedly this omission originates from the val_entry addition being added
> everywhere only after wide-int branch grabbed some add_AT_* routine from
> dwarf2out.c as example for the add_AT_wide addition.
I can indeed confirm this is what happened.
> Bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk
> and 5.1 as obvious.
The fix looks good to me.