This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, i386, Darwin RFT]: Remove reload_in_progress checks
- From: Dominique d'HumiÃres <dominiq at lps dot ens dot fr>
- To: Uros Bizjak <ubizjak at gmail dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Vladimir Makarov <vmakarov at redhat dot com>, Iain Sandoe <iain at codesourcery dot com>
- Date: Mon, 20 Apr 2015 11:47:40 +0200
- Subject: Re: [PATCH, i386, Darwin RFT]: Remove reload_in_progress checks
- Authentication-results: sourceware.org; auth=none
- References: <CAFULd4ZPsqrq1O6kaEtQEkYyucdXNTN-vHyhdDWzXEzPjmdvgg at mail dot gmail dot com>
After having fixed the typo, regtesting went without regression.
Dominique
> Le 19 avr. 2015 Ã 20:35, Uros Bizjak <ubizjak@gmail.com> a Ãcrit :
>
> Hello!
>
> Attached patch removes reload_in_progress checks for x86 (LRA enabled)
> target. AFAICS, reload_in_progress is never set during the
> compilation, a watchpoint on this variable didn't trigger for a couple
> of complex compilations.
>
> 2015-04-19 Uros Bizjak <ubizjak@gmail.com>
>
> * config/i386/i386.c (set_pic_reg_ever_live): Remove.
> (legitimize_pic_address): Do not call set_pic_reg_ever_live.
> (legitimize_tls_address): Ditto.
> (ix86_expand_move): Ditto.
> (ix86_expand_binary_operator): Remove reload_in_progress checks.
> (ix86_expand_unary_operator): Ditto.
> * config/i386/predicates.md (index_register_operand): Ditto.
>
> Patch was bootstrapped on x86_64-linux-gnu and regression tested for
> x86_64-linux-gnu, i686-linux-gnu with and w/o -fpic.
>
> The patch also changes Darwin specific code that can't be tested
> properly on linux. Instead of leaving a reload_in_progress_check
> theere, I'd ask someone to bootstrap and regression test the patch on
> Darwin target.
>
> I'll wait for the Darwin regression test results (and possible
> comments) before committing the patch.
>
> Uros.
> <p.diff.txt>