This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: unused comparison warning (bug 62182)

From: Jeff Law <law at redhat dot com>
To: Marek Polacek <polacek at redhat dot com>, Arnaud Bienner <arnaud dot bienner at gmail dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Fri, 17 Apr 2015 10:16:45 -0600
Subject: Re: unused comparison warning (bug 62182)
Authentication-results: sourceware.org; auth=none
References: <CALZjR+2W2i6H0uBMAQq6MxwwHXrRhP+x65AXwM_HJSQ37oe0qw at mail dot gmail dot com> <20150416084144 dot GG6541 at redhat dot com>

On 04/16/2015 02:41 AM, Marek Polacek wrote:

On Thu, Apr 16, 2015 at 12:51:33AM +0200, Arnaud Bienner wrote:

Hi,

I've submitted a patch to bug 62182 [1], and I would like to have some
feedback about it (this is still WIP as noted in the bug).
As it is my first patch to gcc, I'm not sure what is the best way to
discuss/review patches (here or in bugzilla).
Anyway, please let me know your thoughts :)


Thanks for working on this.  Several comments:

- Do you have a copyright assignment on file?  (Not sure if it's needed for
   this particular patch.)

Probably not needed for this patch, but definitely useful if Arnaudmight have more patches later -- in which case it's good to start thatprocess now.

Jeff

References:
- unused comparison warning (bug 62182)
  - From: Arnaud Bienner
- Re: unused comparison warning (bug 62182)
  - From: Marek Polacek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]