This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch,avr,installed] ad PR65296: Adjust specs to new avr-libc layout as of #44574
- From: Denis Chertykov <chertykov at gmail dot com>
- To: Georg-Johann Lay <avr at gjlay dot de>
- Cc: "Sivanupandi, Pitchumani" <Pitchumani dot Sivanupandi at atmel dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Joerg Wunsch <joerg_wunsch at uriah dot heep dot sax dot de>, "Selvaraj, Senthil_Kumar" <Senthil_Kumar dot Selvaraj at atmel dot com>
- Date: Fri, 17 Apr 2015 17:43:07 +0300
- Subject: Re: [patch,avr,installed] ad PR65296: Adjust specs to new avr-libc layout as of #44574
- Authentication-results: sourceware.org; auth=none
- References: <54F4BCA1 dot 7080707 at gjlay dot de> <20150303132144 dot GC24277 at atmel dot com> <54FDC417 dot 1000008 at gjlay dot de> <CAC140656783604CABA6AE60C2A6D5A49854FE15 at penmbx02 dot corp dot atmel dot com> <5523CEDE dot 1060204 at gjlay dot de> <CADOs=zb_dyo0tEONrff_O7genuOu6Mgg-EWHpg277RBMR=VFoQ at mail dot gmail dot com> <55251030 dot 1070305 at gjlay dot de> <CAC140656783604CABA6AE60C2A6D5A49855BA55 at penmbx02 dot corp dot atmel dot com> <55266135 dot 20003 at gjlay dot de> <CAC140656783604CABA6AE60C2A6D5A49855BB81 at penmbx02 dot corp dot atmel dot com> <CAC140656783604CABA6AE60C2A6D5A49855E892 at penmbx02 dot corp dot atmel dot com> <5531128C dot 3010709 at gjlay dot de>
2015-04-17 17:02 GMT+03:00 Georg-Johann Lay <avr@gjlay.de>:
> ...I went ahead and installed as
>
> http://gcc.gnu.org/r222179
>
> It will be backported to 5.2 as soon as 5.1 is open for patches again
> (assuming RM won't approve this one for 5.1).
IMHO AVR port is not locked for patches.
It's not a primary target.
>
>
> As far as I can tell, all works fine now, even with install-paths containing
> spaces and LTO.
>
>
> Johann
>
>
> 2015-04-17 Sivanupandi Pitchumani <Pitchumani.Sivanupandi@atmel.com>
>
> PR target/65296
> * config/avr/gen-avr-mmcu-specs.c (*avrlibc_startfile): Adjust
> to new AVR-LibC file layout (bug #44574).
> (*avrlibc_devicelib): Same.
> * config/avr/avr-mcus.def: Adjust comments.
> * config/avr/avr.opt (nodevicelib): Adjust help.
>
>
>
> Index: config/avr/gen-avr-mmcu-specs.c
> ===================================================================
> --- config/avr/gen-avr-mmcu-specs.c (revision 222178)
> +++ config/avr/gen-avr-mmcu-specs.c (revision 222179)
> @@ -171,11 +171,11 @@ bool is_arch = NULL == mcu->macro;
> if (is_device)
> {
> fprintf (f, "*avrlibc_startfile:\n");
> - fprintf (f, "\tdev/%s/crt1.o%%s", mcu->name);
> + fprintf (f, "\tcrt%s.o%%s", mcu->name);
> fprintf (f, "\n\n");
>
> fprintf (f, "*avrlibc_devicelib:\n");
> - fprintf (f, "\t%%{!nodevicelib:dev/%s/libdev.a%%s}", mcu->name);
> + fprintf (f, "\t%%{!nodevicelib:-l%s}", mcu->name);
> fprintf (f, "\n\n");
> }
> #endif // WITH_AVRLIBC
> Index: config/avr/avr-mcus.def
> ===================================================================
> --- config/avr/avr-mcus.def (revision 222178)
> +++ config/avr/avr-mcus.def (revision 222179)
> @@ -44,8 +44,8 @@ Before including this file, define a mac
> used by DRIVER_SELF_SPECS and gen-avr-mmcu-specs.c for
> - the name of the device specific specs file
> in -specs=device-specs/spec-<NAME>
> - - the name of the startup file dev/<NAME>/crt1.o
> - - the name of the device library dev/<NAME>/libdev.a
> + - the name of the startup file crt<NAME>.o
> + - to link the device library by means of -l<NAME>
>
> ARCH Specifies the multilib variant together with
> AVR_SHORT_SP
>
> Index: config/avr/avr.opt
> ===================================================================
> --- config/avr/avr.opt (revision 222178)
> +++ config/avr/avr.opt (revision 222179)
> @@ -97,4 +97,4 @@ Allow to use truncation instead of round
>
> nodevicelib
> Driver Target Report RejectNegative
> -Do not link against the device-specific library libdev.a
> +Do not link against the device-specific library lib<MCU>.a
>
- References:
- RE: [patch,avr]: Part2: Fix various problems with specs and specs file generation.
- From: Sivanupandi, Pitchumani
- Re: [patch,avr]: Part2: Fix various problems with specs and specs file generation.
- Re: [patch,avr]: Part2: Fix various problems with specs and specs file generation.
- Re: [patch,avr]: Part2: Fix various problems with specs and specs file generation.
- RE: [patch,avr]: Part2: Fix various problems with specs and specs file generation.
- From: Sivanupandi, Pitchumani
- Re: [patch,avr]: Part2: Fix various problems with specs and specs file generation.
- RE: [patch,avr]: Part2: Fix various problems with specs and specs file generation.
- From: Sivanupandi, Pitchumani
- RE: [patch,avr]: Part2: Fix various problems with specs and specs file generation.
- From: Sivanupandi, Pitchumani
- [patch,avr,installed] ad PR65296: Adjust specs to new avr-libc layout as of #44574