This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] mklog: Fallback to env author name and addr
- From: Bernhard Reutner-Fischer <rep dot dot dot nop at gmail dot com>
- To: Diego Novillo <dnovillo at google dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, Cary Coutant <ccoutant at gmail dot com>
- Date: Wed, 8 Apr 2015 22:04:04 +0200
- Subject: Re: [PATCH] mklog: Fallback to env author name and addr
- Authentication-results: sourceware.org; auth=none
- References: <1428521808-30487-1-git-send-email-rep dot dot dot nop at gmail dot com> <CAD_=9DTJJvN7ag+Yzr1bn0CTdifDR0GWgpvYCK-kPrkMrAc7EQ at mail dot gmail dot com>
On 8 April 2015 at 21:45, Diego Novillo <dnovillo@google.com> wrote:
> On Wed, Apr 8, 2015 at 3:36 PM, Bernhard Reutner-Fischer
> <rep.dot.nop@gmail.com> wrote:
>> contrib/ChangeLog:
>>
>> 2015-04-08 Bernhard Reutner-Fischer <aldot@gcc.gnu.org>
>>
>> * mklog ($name, $addr): Fallback to env author settings.
>
> This looks fine, but note that I no longer have approval rights for
yuck. I remember now, what a pity.
> patches. Code in contrib/ has looser requirements, and the patch is
> clearly harmless. I would just add documentation on the GIT_AUTHOR_*
> environment variables at the top of the script.
I'll document them, thanks!