This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [CHKP] Never expand instrumentation thunks
- From: Jan Hubicka <hubicka at ucw dot cz>
- To: Ilya Enkovich <enkovich dot gnu at gmail dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 2 Apr 2015 22:11:05 +0200
- Subject: Re: [CHKP] Never expand instrumentation thunks
- Authentication-results: sourceware.org; auth=none
- References: <20150318121912 dot GB64546 at msticlxl57 dot ims dot intel dot com> <CAMbmDYbkqXzKT9iuchmnd5-GVbNvsBwDNLocKK1A100hHycSAQ at mail dot gmail dot com>
> > 2015-03-18 Ilya Enkovich <ilya.enkovich@intel.com>
> >
> > * cgraphunit.c (cgraph_node::expand_thunk): Don't expand
> > instrumentation thunks.
> >
> >
> > diff --git a/gcc/cgraphunit.c b/gcc/cgraphunit.c
> > index e640907..abc9cfe 100644
> > --- a/gcc/cgraphunit.c
> > +++ b/gcc/cgraphunit.c
> > @@ -1508,6 +1508,10 @@ cgraph_node::expand_thunk (bool output_asm_thunks, bool force_gimple_thunk)
> > tree thunk_fndecl = decl;
> > tree a;
> >
> > + /* Instrumentation thunk is the same function with
> > + a different signature. Never need to expand it. */
> > + if (thunk.add_pointer_bounds_args)
> > + return false;
Yeah, this is another case where we hit problem with transparent alias pretending
to be thunk :)
I guess the patch is OK for GCC-5 and for next stage1 we can clean this up.
Honza
> >
> > if (!force_gimple_thunk && this_adjusting
> > && targetm.asm_out.can_output_mi_thunk (thunk_fndecl, fixed_offset,