This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH ARM]Fix memset-inline-* failures on cortex-a9 tune by checking tune information.
- From: Ramana Radhakrishnan <ramana dot gcc at googlemail dot com>
- To: "Bin.Cheng" <amker dot cheng at gmail dot com>
- Cc: Bin Cheng <bin dot cheng at arm dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 23 Mar 2015 16:09:53 +0000
- Subject: Re: [PATCH ARM]Fix memset-inline-* failures on cortex-a9 tune by checking tune information.
- Authentication-results: sourceware.org; auth=none
- References: <000401d057e1$a30d2470$e9276d50$ at arm dot com> <CAJA7tRasZkCOFMsby37+=DYsdfLKszwdx6=aXCQr3R_HZJLf5g at mail dot gmail dot com> <CAHFci2-iXXkr3nD3_TtzrFB3pDgLFknxB4dqD3QE029G81YFgA at mail dot gmail dot com>
- Reply-to: ramrad01 at arm dot com
On Tue, Mar 17, 2015 at 3:34 AM, Bin.Cheng <amker.cheng@gmail.com> wrote:
> On Fri, Mar 13, 2015 at 7:56 PM, Ramana Radhakrishnan
> <ramana.gcc@googlemail.com> wrote:
>> On Fri, Mar 6, 2015 at 7:46 AM, Bin Cheng <bin.cheng@arm.com> wrote:
>>> Hi,
>>> This patch is the second part fixing memset-inline-{4,5,6,8,9}.c failures on
>>> cortex-a9. It adds a function checking CPU tuning information in dejagnu,
>>> it also uses that function to skip related testcase when we are compiling
>>> for cortex-a9 tune.
>>
>> Skips the related testcase for all tests where the tuning information
>> doesn't use neon. I think this technique can be used to clean up a
>> number of multilib related failures in the gcc.target/arm testsuite.
> Actually these are all related cases. Cases {1,2,3} are intended for
> non-neon target inlining test, case 7 is an executable test which
> should be run what ever the target supports.
>
>>
>>>
>>> Build and test on arm-none-eabi. Is it OK?
>>>
>>> gcc/testsuite/ChangeLog
>>> 2015-03-06 Bin Cheng <bin.cheng@arm.com>
>>>
>>> * lib/target-supports.exp (arm_tune_string_ops_prefer_neon): New.
>>> * gcc.target/arm/memset-inline-4.c: Skip for
>>> arm_tune_string_ops_prefer_neon.
>>> * gcc.target/arm/memset-inline-5.c: Ditto.
>>> * gcc.target/arm/memset-inline-6.c: Ditto.
>>> * gcc.target/arm/memset-inline-8.c: Ditto.
>>> * gcc.target/arm/memset-inline-9.c: Ditto.
>>
>> Ok, please document the new dejagnu helper routine in sourcebuild.texi
> Done. Patch updated, I will push both patches in if you are ok with it.
>
> Thanks,
> bin
>
> 2015-03-17 Bin Cheng <bin.cheng@arm.com>
> * doc/sourcebuild.texi (arm_tune_string_ops_prefer_neon): New.
>
> gcc/testsuite/ChangeLog
> 2015-03-17 Bin Cheng <bin.cheng@arm.com>
>
> * lib/target-supports.exp (arm_tune_string_ops_prefer_neon): New.
> * gcc.target/arm/memset-inline-4.c: Skip for
> arm_tune_string_ops_prefer_neon.
> * gcc.target/arm/memset-inline-5.c: Ditto.
> * gcc.target/arm/memset-inline-6.c: Ditto.
> * gcc.target/arm/memset-inline-8.c: Ditto.
> * gcc.target/arm/memset-inline-9.c: Ditto.
OK.
Ramana