This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, i386 testsuite]: Require nonpic target for some tests
- From: Uros Bizjak <ubizjak at gmail dot com>
- To: Tom de Vries <Tom_deVries at mentor dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 12 Mar 2015 11:51:12 +0100
- Subject: Re: [PATCH, i386 testsuite]: Require nonpic target for some tests
- Authentication-results: sourceware.org; auth=none
- References: <CAFULd4ZGrVhUyb3tAJTznRS+6whuPnHxNdB-KoAe3A5YJrLOXg at mail dot gmail dot com> <55014A35 dot 6050804 at mentor dot com> <CAFULd4aQnh2a4WhLN8cL-5QOGRr5wtd+NghPSVtcDfz6r+W3_w at mail dot gmail dot com> <55016D74 dot 1080003 at mentor dot com>
On Thu, Mar 12, 2015 at 11:41 AM, Tom de Vries <Tom_deVries@mentor.com> wrote:
>>>> Attached patch adds nonpic target requirement for some (obvious)
>>>> cases, where data access or PIC register setup confuses scan-asms.
>>>>
>>>> 2015-01-30 Uros Bizjak <ubizjak@gmail.com>
>>>>
>>>> * gcc.target/i386/fuse-caller-save-rec.c: Require nonpic target.
>>>> * gcc.target/i386/fuse-caller-save-xmm.c: Ditto.
>>>> * gcc.target/i386/fuse-caller-save.c: Ditto.
>>>
>>>
>>>
>>> Hi,
>>>
>>> I've reverted this part of the patch. The scans were failing because the
>>> -fipa-ra optimization was broken for -m32 -fpic (PR64895).
>>
>>
>> Not really.
>>
>> Allocator is free to allocate %ebx (or other call-saved
>> register) as PIC register.
>>
>> In this case, unwanted push/pop sequence
>> will be emitted.
>>
>
> Sure, but I don't see what that has to do with the test-cases. I don't see a
> pic register used in fuse-caller-save.c and fuse-caller-save-rec.c. I do see
> a pic register used in gcc.target/i386/fuse-caller-save-xmm.c, but there's
> no scan for push/pop sequence in there.
You are right, the call is (obviously) to a local function. There is
no need for PIC reg, so this clears my concerns.
Thanks,
Uros.