This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Fix vectorizer alignment update wrt section anchors
- From: Jan Hubicka <hubicka at ucw dot cz>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Jan Hubicka <hubicka at ucw dot cz>, gcc-patches at gcc dot gnu dot org, richard dot sandiford at arm dot com
- Date: Mon, 9 Mar 2015 18:24:46 +0100
- Subject: Re: Fix vectorizer alignment update wrt section anchors
- Authentication-results: sourceware.org; auth=none
- References: <20150309033857 dot GD50226 at kam dot mff dot cuni dot cz> <20150309171935 dot GV1746 at tucnak dot redhat dot com>
> make_decl_rtl only calls this for:
> if (TREE_CODE (decl) == FUNCTION_DECL
> && cgraph_node::get (decl)
> && cgraph_node::get (decl)->instrumentation_clone)
> Is it intentional you are doing it unconditionally?
Yes, ultimate_transparent_alias_target is either called in make_decl_rtl or in
assemble_name. I do not think there is way the symbol can land into .s file
untranslated.
I must admit I am surprised instrumentation_clones need any special handling here.
instrumentation clones have special cases all over symbol table/cgrap code. I need
to get familiar with these.
>
> > + *t = ggc_strdup (targetm.strip_name_encoding (IDENTIFIER_POINTER (id)));
>
> Otherwise it looks reasonable. Another option would be to just create the
> RTL for notice_global_symbol purposes using make_decl_rtl_for_debug.
Hmm, did not know about this one, but I think avoiding RTL here is best.
Thanks for comments!
Honza
>
> Jakub