This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Improve PR44563
- From: Steven Bosscher <stevenb dot gcc at gmail dot com>
- To: Richard Biener <rguenther at suse dot de>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Jan Hubicka <hubicka at ucw dot cz>
- Date: Mon, 9 Mar 2015 16:48:08 +0100
- Subject: Re: [PATCH] Improve PR44563
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot LSU dot 2 dot 11 dot 1503091610470 dot 10796 at zhemvz dot fhfr dot qr>
On Mon, Mar 9, 2015 at 4:12 PM, Richard Biener wrote:
> ! /* This is a really poor hash function, but it is what the current code uses,
> ! so I am reusing it to avoid an additional axis in testing. */
This is a bit silly as a comment, because after your patch the
"current" code is the patched code. Better to reference the
htab_hash_pointer function.
But can't we add an inline version in hashtab.h instead?
Ciao!
Steven