Re: PR c++/64626 - C++14 single quote should not always be a digit separator

[Ed Smith-Rowland <3dw4rd at verizon dot net>]

On 03/08/2015 02:52 PM, Jakub Jelinek wrote:
> On Sun, Mar 08, 2015 at 02:33:03PM -0400, Ed Smith-Rowland wrote:
> > I just look to see if a lexed number in libcpp ends in a '.
> > If so, back up one character and let string processing handle it.
> >
> > I get one warning and one error for each instance but I'd rather not error
> > when it should pass.
> >
> > Built and tests clean on x86_64-linux.
> >
> > OK?
> >
> >
> > libcpp/
> >
> > 2015-03-09  Edward Smith-Rowland  <3dw4rd@verizon.net>
> >
> > 	PR c++/64626
> > 	* expr.c (parse_has_attribute): New function; (eval_token): Look for
> > 	__has_attribute__ and route to parse_has_attribute.
> This ChangeLog entry doesn't match the patch, you've changed
> lex.c (lex_number) instead...
>
> > --- libcpp/lex.c	(revision 221218)
> > +++ libcpp/lex.c	(working copy)
> > @@ -1400,6 +1400,9 @@
> >   	  NORMALIZE_STATE_UPDATE_IDNUM (nst, *cur);
> >   	  cur++;
> >   	}
> > +      /* A number can't end with a digit separator.  */
> > +      if (DIGIT_SEP (cur[-1]))
> > +	--cur;
> >   
> >         pfile->buffer->cur = cur;
> >       }
> 	Jakub
Sigh.  A paste-o from another CL entry.

Also, I decided I should treat the following:

0'';
123''''';

It won't hurt and it's easy.

Here is a new patch and CL.

Ed

Attachment: patch_pr64626_3
Description: Text document

Attachment: CL_pr64626_2
Description: Text document