This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH, libgfortran] PR 65200 Handle EPERM as EACCES

From: Jerry DeLisle <jvdelisle at charter dot net>
To: Janne Blomqvist <blomqvist dot janne at gmail dot com>, Fortran List <fortran at gcc dot gnu dot org>, GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Sat, 07 Mar 2015 09:09:50 -0800
Subject: Re: [PATCH, libgfortran] PR 65200 Handle EPERM as EACCES
Authentication-results: sourceware.org; auth=none
References: <CAO9iq9HRO_2gzY0Cv0B4R_LgDx5=5RoNfitS04B_EDTnAPA1mg at mail dot gmail dot com>

On 03/06/2015 04:23 PM, Janne Blomqvist wrote:

The patch as is causes gfortran.dg/open_errors.f90 to fail, due to
changed error messages. I'm a bit unsure of to fix this, as now
strerror* is used to generate part of the message, and thus the
message can be different on different targets, and even dependent on
the locale settings. Just checking for the fixed part of the error
message doesn't seem that useful in this case; should the entire
testcase just be removed?

Generally the patch is OK as FX has stated. I am concerned about the strerrormessages being less helpful to users than the ones we have. However, you caneither keep the same error messages for those few or update the test case to usethe error codes (iostat) if that makes more sense.


Jerry

References:
- [PATCH, libgfortran] PR 65200 Handle EPERM as EACCES
  - From: Janne Blomqvist

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]