This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] libgcc: Don't use "unused" in gthr-single.h
- From: Jack Howarth <howarth dot at dot gcc at gmail dot com>
- To: Segher Boessenkool <segher at kernel dot crashing dot org>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Sun, 22 Feb 2015 22:17:50 -0500
- Subject: Re: [PATCH] libgcc: Don't use "unused" in gthr-single.h
- Authentication-results: sourceware.org; auth=none
- References: <412f749ad6a8a240748a580e7f01fb641be5ce44 dot 1424657530 dot git dot segher at kernel dot crashing dot org>
This change has already been proposed as part of a more extensive fix
in https://gcc.gnu.org/ml/gcc-patches/2015-02/msg00775.html.
On Sun, Feb 22, 2015 at 9:28 PM, Segher Boessenkool
<segher@kernel.crashing.org> wrote:
> Header files shouldn't use identifiers in the application namespace.
> gth-single.h does however; this makes the libstdc++ testsuite
> all_attributes.cc fail for targets without software threads.
>
> Is this okay for mainline? And 4.9, 4.8?
>
>
> Segher
>
>
> 2015-02-22 Segher Boessenkool <segher@kernel.crashing.org>
>
> libgcc/
> * gthr-single.h: Use __unused__ instead of unused.
>
> ---
> libgcc/gthr-single.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libgcc/gthr-single.h b/libgcc/gthr-single.h
> index f084fe2..bddded4 100644
> --- a/libgcc/gthr-single.h
> +++ b/libgcc/gthr-single.h
> @@ -38,7 +38,7 @@ typedef int __gthread_recursive_mutex_t;
> #define __GTHREAD_MUTEX_INIT_FUNCTION(mx)
> #define __GTHREAD_RECURSIVE_MUTEX_INIT 0
>
> -#define UNUSED __attribute__((unused))
> +#define UNUSED __attribute__((__unused__))
>
> #ifdef _LIBOBJC
>
> --
> 1.8.1.4
>