This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix testsuite race on additional_sources
- From: Maxim Kuvyrkov <maxim dot kuvyrkov at linaro dot org>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 19 Feb 2015 16:33:46 +0300
- Subject: Re: [PATCH] Fix testsuite race on additional_sources
- Authentication-results: sourceware.org; auth=none
- References: <116EBDE8-03C2-4F65-BE0B-23AB92635FD7 at linaro dot org> <CAMe9rOoX8_tauapTyNR7FRKYmKYU6tiBzmWF7w1QmfWARc=39w at mail dot gmail dot com>
> On Feb 19, 2015, at 4:31 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Wed, Feb 18, 2015 at 7:05 AM, Maxim Kuvyrkov
> <maxim.kuvyrkov@linaro.org> wrote:
>> Hi,
>>
>> This testsuite patch fixes race on additional_source testsuite variable. When a test has both dg-additional-sources and "dg-do run { target FOO }" directives, it may occur that the FOO test will attempt to use additional_sources, which will result in failure to compile FOO test. It often happens that FOO test was done for one of the previous testcases (which didn't use dg-additional-sources), so the failure case is not stable.
>>
>> This behavior can be more-or-less reliably triggered with
>>
>> make check-gcc make RUNTESTFLAGS="i386.exp=gcc.target/i386/pr64291-1.c"
>>
>> The attached patch fixes the problem. OK for trunk and 4.9 branch?
>>
>
> It caused:
>
> ERROR: 17_intro/shared_with_static_deps.cc: can't read
> "additional_sources": no such variable for "
> dg-require-effective-target 4 fpic "
Yes, this is PR65116. I've screwed up testing of the patch. Reverted on 4.9 branch for now, and will post a fix for trunk shortly.
--
Maxim Kuvyrkov
www.linaro.org