Re: [PATCH] Fix testsuite race on additional_sources

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Wed, Feb 18, 2015 at 7:05 AM, Maxim Kuvyrkov
<maxim.kuvyrkov@linaro.org> wrote:
> Hi,
>
> This testsuite patch fixes race on additional_source testsuite variable.  When a test has both dg-additional-sources and "dg-do run { target FOO }" directives, it may occur that the FOO test will attempt to use additional_sources, which will result in failure to compile FOO test.  It often happens that FOO test was done for one of the previous testcases (which didn't use dg-additional-sources), so the failure case is not stable.
>
> This behavior can be more-or-less reliably triggered with
>
> make check-gcc make RUNTESTFLAGS="i386.exp=gcc.target/i386/pr64291-1.c"
>
> The attached patch fixes the problem.  OK for trunk and 4.9 branch?
>

It caused:

ERROR: 17_intro/shared_with_static_deps.cc: can't read
"additional_sources": no such variable for "
dg-require-effective-target 4 fpic "
ERROR: 18_support/type_info/fundamental.cc: can't read
"additional_sources": no such variable for "
dg-require-effective-target 2 dfp "
ERROR: 21_strings/c_strings/char/3_neg.cc: can't read
"additional_sources": no such variable for " dg-do 1 compile { target
correct_iso_cpp_string_wchar_protos } "
ERROR: 21_strings/c_strings/wchar_t/3_neg.cc: can't read
"et_cache(correct_iso_cpp_string_wchar_protos,value)": no such element
in array for " dg-do 1 compile { target
correct_iso_cpp_string_wchar_protos } "
ERROR: 22_locale/collate/compare/wchar_t/2.cc: can't read
"additional_sources": no such variable for " dg-require-iconv 4
"ISO8859-1" "
ERROR: 22_locale/collate/compare/wchar_t/wrapped_env.cc: can't read
"additional_sources": no such variable for " dg-require-iconv 4
"ISO8859-1" "
ERROR: 22_locale/collate/compare/wchar_t/wrapped_locale.cc: can't read
"additional_sources": no such variable for " dg-require-iconv 4
"ISO8859-1" "
ERROR: 22_locale/collate/hash/wchar_t/2.cc: can't read
"additional_sources": no such variable for " dg-require-iconv 4
"ISO8859-1" "
ERROR: 22_locale/collate/hash/wchar_t/wrapped_env.cc: can't read
"additional_sources": no such variable for " dg-require-iconv 4
"ISO8859-1" "
ERROR: 22_locale/collate/hash/wchar_t/wrapped_locale.cc: can't read
"additional_sources": no such variable for " dg-require-iconv 4
"ISO8859-1" "
ERROR: 22_locale/collate/transform/wchar_t/2.cc: can't read
"additional_sources": no such variable for " dg-require-iconv 4
"ISO8859-1" "
ERROR: 22_locale/collate/transform/wchar_t/wrapped_env.cc: can't read
"additional_sources": no such variable for " dg-require-iconv 4
"ISO8859-1" "
ERROR: 22_locale/collate/transform/wchar_t/wrapped_locale.cc: can't
read "additional_sources": no such variable for " dg-require-iconv 4
"ISO8859-1" "
ERROR: 22_locale/locale/cons/unicode.cc: can't read
"additional_sources": no such variable for " dg-require-iconv 1
"ISO-8859-1" "
ERROR: 22_locale/num_get/get/char/2.cc: can't read
"additional_sources": no such variable for " dg-do 22 run { xfail
lax_strtofp } "
ERROR: 22_locale/num_get/get/wchar_t/2.cc: can't read
"additional_sources": no such variable for " dg-do 22 run { xfail
lax_strtofp } "
ERROR: 22_locale/time_put/put/wchar_t/10.cc: can't read
"et_cache(uclibc,value)": no such element in array for " dg-do 22 run
{ xfail dummy_wcsftime } "
ERROR: 22_locale/time_put/put/wchar_t/1.cc: can't read
"additional_sources": no such variable for " dg-do 22 run { xfail
dummy_wcsftime } "
ERROR: 22_locale/time_put/put/wchar_t/5.cc: can't read
"et_cache(uclibc,value)": no such element in array for " dg-do 22 run
{ xfail dummy_wcsftime } "
ERROR: 22_locale/time_put/put/wchar_t/9.cc: can't read
"et_cache(uclibc,value)": no such element in array for " dg-do 22 run
{ xfail dummy_wcsftime } "
ERROR: 23_containers/map/modifiers/erase/dr130-linkage-check.cc: can't
read "additional_sources": no such variable for "
dg-require-effective-target 1 ia32 "
ERROR: 23_containers/multimap/modifiers/erase/dr130-linkage-check.cc:
can't read "et_cache(ia32,value)": no such element in array for "
dg-require-effective-target 1 ia32 "
ERROR: 23_containers/multiset/modifiers/erase/dr130-linkage-check.cc:
can't read "et_cache(ia32,value)": no such element in array for "
dg-require-effective-target 1 ia32 "
ERROR: 23_containers/set/modifiers/erase/dr130-linkage-check.cc: can't
read "additional_sources": no such variable for "
dg-require-effective-target 1 ia32 "
ERROR: 26_numerics/headers/cmath/c99_classification_macros_c++0x.cc:
can't read "et_cache(uclibc,value)": no such element in array for "
dg-do 19 compile { xfail uclibc } "
ERROR: 26_numerics/headers/cmath/c99_classification_macros_c++.cc:
can't read "et_cache(uclibc,value)": no such element in array for "
dg-do 21 compile { xfail uclibc } "
ERROR: 27_io/basic_filebuf/close/char/4879.cc: can't read
"additional_sources": no such variable for " dg-require-fork 1 "" "
ERROR: 27_io/basic_filebuf/close/char/9964.cc: can't read
"et_cache(fork_available,value)": no such element in array for "
dg-require-fork 1 "" "
ERROR: 27_io/basic_filebuf/imbue/char/13171-2.cc: can't read
"et_cache(fork_available,value)": no such element in array for "
dg-require-fork 3 "" "
ERROR: 27_io/basic_filebuf/imbue/char/13582-2.cc: can't read
"et_cache(fork_available,value)": no such element in array for "
dg-require-fork 3 "" "
ERROR: 27_io/basic_filebuf/imbue/wchar_t/13582-2.cc: can't read
"additional_sources": no such variable for " dg-require-fork 3 "" "
ERROR: 27_io/basic_filebuf/imbue/wchar_t/14975-2.cc: can't read
"et_cache(fork_available,value)": no such element in array for "
dg-require-fork 2 "" "
ERROR: 27_io/basic_filebuf/open/char/9507.cc: can't read
"additional_sources": no such variable for " dg-require-mkfifo 1 "" "
ERROR: 27_io/basic_filebuf/seekoff/char/26777.cc: can't read
"additional_sources": no such variable for " dg-require-fork 1 "" "
ERROR: 27_io/basic_filebuf/showmanyc/char/9533-1.cc: can't read
"additional_sources": no such variable for " dg-require-fork 1 "" "
ERROR: 27_io/basic_filebuf/underflow/char/10097.cc: can't read
"et_cache(fork_available,value)": no such element in array for "
dg-require-fork 1 "" "
ERROR: 27_io/basic_istream/extractors_arithmetic/char/09.cc: can't
read "et_cache(uclibc,value)": no such element in array for " dg-do 22
run { xfail lax_strtofp } "
ERROR: 27_io/basic_istream/extractors_arithmetic/char/12.cc: can't
read "et_cache(uclibc,value)": no such element in array for " dg-do 22
run { xfail { lax_strtofp } } "
ERROR: 27_io/basic_istream/extractors_arithmetic/wchar_t/09.cc: can't
read "additional_sources": no such variable for " dg-do 20 run { xfail
lax_strtofp } "
ERROR: 27_io/basic_istream/extractors_arithmetic/wchar_t/12.cc: can't
read "additional_sources": no such variable for " dg-do 20 run { xfail
{ lax_strtofp } } "
ERROR: 27_io/basic_ostream/inserters_arithmetic/char/6.cc: can't read
"et_cache(uclibc,value)": no such element in array for " dg-do 21 run
{ xfail lax_strtofp } "
ERROR: 27_io/basic_ostream/inserters_arithmetic/wchar_t/6.cc: can't
read "et_cache(uclibc,value)": no such element in array for " dg-do 18
run { xfail lax_strtofp } "
ERROR: 27_io/objects/char/7.cc: can't read "additional_sources": no
such variable for " dg-require-fork 1 "" "
ERROR: 27_io/objects/char/9661-1.cc: can't read
"et_cache(fork_available,value)": no such element in array for "
dg-require-fork 1 "" "
ERROR: 27_io/objects/wchar_t/7.cc: can't read
"et_cache(fork_available,value)": no such element in array for "
dg-require-fork 1 "" "
ERROR: 27_io/objects/wchar_t/9661-1.cc: can't read
"et_cache(fork_available,value)": no such element in array for "
dg-require-fork 1 "" "
ERROR: 28_regex/traits/char/isctype.cc: can't read
"additional_sources": no such variable for " dg-additional-options 3
"-DNEWLINE_IN_CLASS_BLANK" { target newlib } "
ERROR: 28_regex/traits/wchar_t/isctype.cc: can't read
"additional_sources": no such variable for " dg-additional-options 3
"-DNEWLINE_IN_CLASS_BLANK" { target newlib } "
ERROR: 29_atomics/atomic_flag/test_and_set/explicit-hle.cc: can't read
"et_cache(ia32,value)": no such element in array for " dg-options 3
"-std=gnu++11 -g0 -fno-exceptions -fno-asynchronous-unwind-tables
-march=i486" { target ia32 } "
ERROR: can't read "additional_sources": no such variable
ERROR: can't read "et_cache(ia32,value)": no such element in array
ERROR: can't read "et_cache(ia32,value)": no such element in array
ERROR: decimal/binary-arith.cc: can't read "additional_sources": no
such variable for " dg-require-effective-target 18 dfp "
ERROR: decimal/cast_neg.cc: can't read "et_cache(dfp,value)": no such
element in array for " dg-require-effective-target 19 dfp "
ERROR: decimal/comparison.cc: can't read "et_cache(dfp,value)": no
such element in array for " dg-require-effective-target 18 dfp "
ERROR: decimal/compound-assignment.cc: can't read
"et_cache(dfp,value)": no such element in array for "
dg-require-effective-target 18 dfp "
ERROR: decimal/compound-assignment-memfunc.cc: can't read
"et_cache(dfp,value)": no such element in array for "
dg-require-effective-target 18 dfp "
ERROR: decimal/conversion-from-float.cc: can't read
"et_cache(dfp,value)": no such element in array for "
dg-require-effective-target 18 dfp "
ERROR: decimal/conversion-from-integral.cc: can't read
"et_cache(dfp,value)": no such element in array for "
dg-require-effective-target 18 dfp "
ERROR: decimal/conversion-to-generic-float.cc: can't read
"et_cache(dfp,value)": no such element in array for "
dg-require-effective-target 18 dfp "
ERROR: decimal/conversion-to-integral.cc: can't read
"et_cache(dfp,value)": no such element in array for "
dg-require-effective-target 18 dfp "
ERROR: decimal/ctor.cc: can't read "et_cache(dfp,value)": no such
element in array for " dg-require-effective-target 18 dfp "
ERROR: decimal/incdec.cc: can't read "et_cache(dfp,value)": no such
element in array for " dg-require-effective-target 18 dfp "
ERROR: decimal/incdec-memfunc.cc: can't read "et_cache(dfp,value)": no
such element in array for " dg-require-effective-target 18 dfp "
ERROR: decimal/make-decimal.cc: can't read "et_cache(dfp,value)": no
such element in array for " dg-require-effective-target 18 dfp "
ERROR: decimal/mixed-mode-arith_neg.cc: can't read
"et_cache(dfp,value)": no such element in array for "
dg-require-effective-target 19 dfp "
ERROR: decimal/mixed-mode-cmp_neg.cc: can't read
"et_cache(dfp,value)": no such element in array for "
dg-require-effective-target 19 dfp "
ERROR: decimal/operator_neg.cc: can't read "et_cache(dfp,value)": no
such element in array for " dg-require-effective-target 19 dfp "
ERROR: decimal/pr54036-1.cc: can't read "et_cache(dfp,value)": no such
element in array for " dg-require-effective-target 18 dfp "
ERROR: decimal/pr54036-2.cc: can't read "et_cache(dfp,value)": no such
element in array for " dg-require-effective-target 18 dfp "
ERROR: decimal/pr54036-3.cc: can't read "et_cache(dfp,value)": no such
element in array for " dg-require-effective-target 18 dfp "
ERROR: decimal/pr58815.cc: can't read "et_cache(dfp,value)": no such
element in array for " dg-require-effective-target 21 dfp "
ERROR: decimal/unary-arith.cc: can't read "et_cache(dfp,value)": no
such element in array for " dg-require-effective-target 18 dfp "
ERROR: ext/codecvt/1.cc: can't read "additional_sources": no such
variable for " dg-require-iconv 1 "UCS-2BE" "
ERROR: ext/codecvt/char-1.cc: can't read "additional_sources": no such
variable for " dg-require-iconv 1 "UCS-2BE" "
ERROR: ext/codecvt/char-2.cc: can't read "additional_sources": no such
variable for " dg-require-iconv 1 "UCS-2LE" "
ERROR: ext/codecvt/wchar_t.cc: can't read "additional_sources": no
such variable for " dg-require-iconv 1 "UCS-2BE" "
ERROR: ext/enc_filebuf/char/13189.cc: can't read "additional_sources":
no such variable for " dg-require-iconv 1 "ISO-8859-1" "
ERROR: ext/enc_filebuf/char/13598.cc: can't read "additional_sources":
no such variable for " dg-require-iconv 5 "ISO-8859-1" "
ERROR: ext/enc_filebuf/wchar_t/13189.cc: can't read
"additional_sources": no such variable for " dg-require-iconv 1
"ISO-8859-1" "
ERROR: ext/mt_allocator/deallocate_local-6.cc: can't read
"additional_sources": no such variable for " dg-require-cxa-atexit 1
"" "
ERROR: ext/mt_allocator/deallocate_local-8.cc: can't read
"et_cache(cxa_atexit_available,value)": no such element in array for "
dg-require-cxa-atexit 1 "" "
ERROR: ext/mt_allocator/deallocate_local_thread-5.cc: can't read
"et_cache(cxa_atexit_available,value)": no such element in array for "
dg-require-cxa-atexit 1 "" "
ERROR: ext/mt_allocator/deallocate_local_thread-7.cc: can't read
"et_cache(cxa_atexit_available,value)": no such element in array for "
dg-require-cxa-atexit 1 "" "
ERROR: ext/new_allocator/deallocate_global.cc: can't read
"additional_sources": no such variable for " dg-require-cxa-atexit 1
"" "
ERROR: ext/profile/all.cc: can't read "additional_sources": no such
variable for " dg-options 2 "-std=gnu++11 -O0
-D_GLIBCXX_PROFILE_NO_THREADS" { target { ! tls_native } } "
ERROR: ext/throw_allocator/deallocate_global.cc: can't read
"et_cache(cxa_atexit_available,value)": no such element in array for "
dg-require-cxa-atexit 1 "" "
ERROR: tcl error sourcing
/export/gnu/import/git/gcc-test-x32/src-trunk/libffi/testsuite/libffi.call/call.exp.
ERROR: tcl error sourcing
/export/gnu/import/git/gcc-test-x32/src-trunk/libffi/testsuite/libffi.complex/complex.exp.
ERROR: tcl error sourcing
/export/gnu/import/git/gcc-test-x32/src-trunk/libffi/testsuite/libffi.go/go.exp.


-- 
H.J.