This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Hi, On 12/01/2014 09:59 PM, Jason Merrill wrote:
On 12/01/2014 07:01 AM, Fabien Chêne wrote:2014-11-03 21:18 GMT+01:00 Fabien Chêne <fabien.chene@gmail.com>:2014-10-09 15:34 GMT+02:00 Jason Merrill <jason@redhat.com>: [...]If the USING_DECL is returned, the code below will be rejected as expected, but the error message will not mention the line where the USING_DECL appears as the previous definition, but at the target declaration of the USING_DECL instead.I think that's what happens if you strip the USING_DECL and return what it points to; if you return the USING_DECL itself that shouldn't happen (thoughthen the caller needs to be able to deal with getting a USING_DECL).[Sorry for the delay] Humm, l_a_c_t returns a TYPE upon success, shall I change it and return a DECL instead ?Ping. Before I made the change, I'd like to be sure this is what you have in mind.I think that makes sense.
Today I was having a look to this pending issue and went astray due to the broken thread: I wondered if, basing on Fabien' first try and the comments accompanying tag_scope, it would make sense to use strip_using_decl only when the scope is ts_global (or maybe != ts_current)?!? The below certainly passes testing. Unless of course Fabien has the above implemented and ready (I don't, I miss the correct changes to the lookup_and_check_tag callers)
Thanks, Paolo. /////////////////
Attachment:
p
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |