Re: RFA: RL78: Fix gcc testsuite failures

[Jan-Benedict Glaw <jbglaw at lug-owl dot de>]

On Wed, 2015-02-04 11:14:16 +0000, Nick Clifton <nickc@redhat.com> wrote:
>   Please can I apply the patch below to fix some RL78 gcc testsuite
>   failures ?
[...]
>   The second fix is to the RL78 specific dead-code elimination pass
>   which was failing to note the REGs inside a MEM are used when that MEM
>   is the destination of a SET insn.
> 
>   Tested with no regressions and lots of fixes using an rl78-elf
>   toolchain.
> 
>   OK to apply ?

Seems you accidentally committed quite some more code you're currently
working on in that very commit, which is now breaking (see eg.
http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=417627):

[...]
g++ -c   -g -O2 -DIN_GCC  -DCROSS_DIRECTORY_STRUCTURE  -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common  -DHAVE_CONFIG_H -I. -I. -I/home/jbglaw/repos/gcc/gcc -I/home/jbglaw/repos/gcc/gcc/. -I/home/jbglaw/repos/gcc/gcc/../include -I/home/jbglaw/repos/gcc/gcc/../libcpp/include  -I/home/jbglaw/repos/gcc/gcc/../libdecnumber -I/home/jbglaw/repos/gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I/home/jbglaw/repos/gcc/gcc/../libbacktrace   -o rl78.o -MT rl78.o -MMD -MP -MF ./.deps/rl78.TPo /home/jbglaw/repos/gcc/gcc/config/rl78/rl78.c
/home/jbglaw/repos/gcc/gcc/config/rl78/rl78.c: In function âtree_node* rl78_handle_func_attribute(tree_node**, tree_node*, tree_node*, int, bool*)â:
/home/jbglaw/repos/gcc/gcc/config/rl78/rl78.c:728: warning: unknown conversion type character âEâ in format
/home/jbglaw/repos/gcc/gcc/config/rl78/rl78.c:728: warning: too many arguments for format
/home/jbglaw/repos/gcc/gcc/config/rl78/rl78.c: In function âtree_node* rl78_handle_saddr_attribute(tree_node**, tree_node*, tree_node*, int, bool*)â:
/home/jbglaw/repos/gcc/gcc/config/rl78/rl78.c:775: warning: unknown conversion type character âEâ in format
/home/jbglaw/repos/gcc/gcc/config/rl78/rl78.c:775: warning: too many arguments for format
/home/jbglaw/repos/gcc/gcc/config/rl78/rl78.c: In function âvoid rl78_alloc_physical_registers()â:
/home/jbglaw/repos/gcc/gcc/config/rl78/rl78.c:3465: error: âVALLOC_DIVHIâ was not declared in this scope
/home/jbglaw/repos/gcc/gcc/config/rl78/rl78.c:3470: error: âVALLOC_DIVSIâ was not declared in this scope
/home/jbglaw/repos/gcc/gcc/config/rl78/rl78.c:3512: error: âVALLOC_DIVSIâ was not declared in this scope
/home/jbglaw/repos/gcc/gcc/config/rl78/rl78.c:3519: error: âVALLOC_DIVHIâ was not declared in this scope
/home/jbglaw/repos/gcc/gcc/config/rl78/rl78.c: In function âvoid set_origin(rtx_def*, rtx_insn*, int*, int*)â:
/home/jbglaw/repos/gcc/gcc/config/rl78/rl78.c:3838: error: âVALLOC_DIVHIâ was not declared in this scope
/home/jbglaw/repos/gcc/gcc/config/rl78/rl78.c:3857: error: âVALLOC_DIVSIâ was not declared in this scope
make[1]: *** [rl78.o] Error 1


With a more recent compiler, that condenses to:

[...]
g++ -c   -g -O2 -DIN_GCC  -DCROSS_DIRECTORY_STRUCTURE  -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common  -DHAVE_CONFIG_H -I. -I. -I../../gcc/gcc -I../../gcc/gcc/. -I../../gcc/gcc/../include -I../../gcc/gcc/../libcpp/include  -I../../gcc/gcc/../libdecnumber -I../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I../../gcc/gcc/../libbacktrace   -o rl78.o -MT rl78.o -MMD -MP -MF ./.deps/rl78.TPo ../../gcc/gcc/config/rl78/rl78.c
../../gcc/gcc/config/rl78/rl78.c: In function âvoid rl78_alloc_physical_registers()â:
../../gcc/gcc/config/rl78/rl78.c:3465:33: error: âVALLOC_DIVHIâ was not declared in this scope
       else if (valloc_method == VALLOC_DIVHI)
                                 ^
../../gcc/gcc/config/rl78/rl78.c:3470:33: error: âVALLOC_DIVSIâ was not declared in this scope
       else if (valloc_method == VALLOC_DIVSI)
                                 ^
../../gcc/gcc/config/rl78/rl78.c:3512:7: error: âVALLOC_DIVSIâ was not declared in this scope
  case VALLOC_DIVSI:
       ^
../../gcc/gcc/config/rl78/rl78.c:3519:7: error: âVALLOC_DIVHIâ was not declared in this scope
  case VALLOC_DIVHI:
       ^
../../gcc/gcc/config/rl78/rl78.c: In function âvoid set_origin(rtx, rtx_insn*, int*, int*)â:
../../gcc/gcc/config/rl78/rl78.c:3838:38: error: âVALLOC_DIVHIâ was not declared in this scope
   else if (get_attr_valloc (insn) == VALLOC_DIVHI)
                                      ^
../../gcc/gcc/config/rl78/rl78.c:3857:38: error: âVALLOC_DIVSIâ was not declared in this scope
   else if (get_attr_valloc (insn) == VALLOC_DIVSI)
                                      ^
make[1]: *** [rl78.o] Error 1



MfG, JBG

-- 
      Jan-Benedict Glaw      jbglaw@lug-owl.de              +49-172-7608481
Signature of:         Alles wird gut! ...und heute wirds schon ein biÃchen besser.
the second  :

Attachment: signature.asc
Description: Digital signature