This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch ARM] Improve guality tests - part 1 - pr36728-1.c
- From: Jakub Jelinek <jakub at redhat dot com>
- To: ramrad01 at arm dot com
- Cc: Ramana Radhakrishnan <ramana dot radhakrishnan at arm dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>, segher at gcc dot gnu dot org
- Date: Wed, 4 Feb 2015 12:10:19 +0100
- Subject: Re: [Patch ARM] Improve guality tests - part 1 - pr36728-1.c
- Authentication-results: sourceware.org; auth=none
- References: <54D1EF49 dot 5080809 at arm dot com> <CAJA7tRa-qEwkLE1tGZ=5w2agJuaUHj5OmKaPiz0Yyq7LuVvX-g at mail dot gmail dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, Feb 04, 2015 at 11:03:29AM +0000, Ramana Radhakrishnan wrote:
> >
> > Changelog:
> >
> > * gcc.dg/guality/pr36728-1.c: Skip some tests for arm.
> >
>
> Segher and I discussed an alternative approach - marking these as "m"
> (arg1) , "m" (arg2) .... etc in the asm blocks also gives us the same
> effect and then probably removes the need to rely on such target
> markers. I've just noticed that the AArch64 port has the same issues.
I don't think it is a good idea to significantly change the function being
tested. Then it tests completely different thing from what it is meant to
test.
But in the pr36728-{1,2}.c case, perhaps you could instead change the
caller, by adding
asm volatile ("" : : "r" (l));
before return 0; in main, that way DW_OP_GNU_entry_value could work if there
is no other way to find the value of the arguments, because l will need to
live somewhere (in some register or memory) across the foo call.
Jakub